Skip to content

Make Pretty formats even prettier.#49537

Merged
alexey-milovidov merged 7 commits intomasterfrom
pretty-time-squashing
May 7, 2023
Merged

Make Pretty formats even prettier.#49537
alexey-milovidov merged 7 commits intomasterfrom
pretty-time-squashing

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented May 5, 2023

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Make Pretty formats prettier: squash blocks if not much time passed since the output of the previous block. This is controlled by a new setting output_format_pretty_squash_ms (100ms by default). This closes #49153

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-improvement Pull request with some product improvements label May 5, 2023
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented May 5, 2023 •
edited
Loading

This is an automated comment for commit 3a079dc with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🔴 failure
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

qoega
qoega approved these changes May 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@qoega qoega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But tests on Pretty formats need to be updated.

@qoega qoega self-assigned this May 5, 2023
@alexey-milovidov alexey-milovidov changed the title Pretty time squashing Make Pretty formats even prettier. May 5, 2023
@alexey-milovidov alexey-milovidov merged commit df8c930 into master May 7, 2023
@alexey-milovidov alexey-milovidov deleted the pretty-time-squashing branch May 7, 2023 14:41
@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented May 12, 2023

Unfortunately, a bug has been found:

milovidov-desktop :) SET output_format_pretty_squash_ms = 0

SET output_format_pretty_squash_ms = 0

Query id: 70929639-98d4-42d6-bc5e-b3a445c4e333

Ok.

0 rows in set. Elapsed: 0.000 sec. 

milovidov-desktop :) SELECT DISTINCT length(*) FROM file('embeddings2.tsv')

SELECT DISTINCT length(*)
FROM file('embeddings2.tsv')

Query id: f5af7aee-a96a-484e-ac6f-33d7cd3a9068

┌─length(c1)─┐
│        384 │
└────────────┘
Cancelling query.
Query was cancelled.

1 row in set. Elapsed: 1.946 sec. Processed 428.98 thousand rows, 1.49 GB (220.44 thousand rows/s., 763.59 MB/s.)

milovidov-desktop :) SET output_format_pretty_squash_ms = 1

SET output_format_pretty_squash_ms = 1

Query id: 43ae64a4-c0d4-4bf3-b39b-6667b8ba5b5b

Ok.

0 rows in set. Elapsed: 0.000 sec. 

milovidov-desktop :) SELECT DISTINCT length(*) FROM file('embeddings2.tsv')

SELECT DISTINCT length(*)
FROM file('embeddings2.tsv')

Query id: 30c0c029-7957-4832-b803-730f4c75c3d5

┌─length(c1)─┐
│        384 │
└────────────┘
Cancelling query.
Query was cancelled.

1 row in set. Elapsed: 1.648 sec. Processed 552.09 thousand rows, 1.91 GB (334.90 thousand rows/s., 1.16 GB/s.)

milovidov-desktop :) SET output_format_pretty_squash_ms = 100

SET output_format_pretty_squash_ms = 100

Query id: dcfc00bf-47e8-4d76-b414-8af3e503e7e8

Ok.

0 rows in set. Elapsed: 0.000 sec. 

milovidov-desktop :) SELECT DISTINCT length(*) FROM file('embeddings2.tsv')

SELECT DISTINCT length(*)
FROM file('embeddings2.tsv')

Query id: cb6fb3ec-9d1f-4e47-9459-9235900337df

Cancelling query.
┌─length(c1)─┐
│        384 │
└────────────┘
Query was cancelled.

1 row in set. Elapsed: 12.930 sec. Processed 3.55 million rows, 12.28 GB (274.28 thousand rows/s., 950.10 MB/s.)

See the last example - it does not output even after 100ms.

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented May 12, 2023

Funny, but this problem is not easily fixable.
It requires an additional processor instead of changing the format.

@alexey-milovidov alexey-milovidov mentioned this pull request May 12, 2023
Merged
@alexey-milovidov alexey-milovidov mentioned this pull request Dec 26, 2024
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qoega qoega qoega approved these changes

Assignees

@qoega qoega

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pretty formats: squash blocks if not much time passed since output of the previous block.

4 participants

@alexey-milovidov @robot-ch-test-poll3 @qoega @robot-clickhouse