Skip to content

Deprecate in-memory parts#49429

Merged
alexey-milovidov merged 13 commits intomasterfrom
deprecate-in-memory-parts
May 8, 2023
Merged

Deprecate in-memory parts#49429
alexey-milovidov merged 13 commits intomasterfrom
deprecate-in-memory-parts

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented May 2, 2023 •
edited
Loading

Changelog category (leave one):

  • Backward Incompatible Change

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Remove the experimental feature "in-memory data parts". The data format is still supported, but the settings are no-op, and compact or wide parts will be used instead. This closes #45409.

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backward-incompatible Pull request with backwards incompatible changes label May 2, 2023
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented May 2, 2023 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit 3cf1da7 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🔴 failure
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@CheSema CheSema self-assigned this May 3, 2023
@CheSema
Copy link
Copy Markdown
Member

CheSema commented May 3, 2023

There are some count of tests with InMemoryParts. I see that you are deleting them.
Hovewer the one has to be remain at least. Lets choose one or write new one.
That test has to check that new server is able to read old wal.bin. I see in the code that it should, but the test protects that code from unexpected changes. That test will participate in upgrade check. Upgrade check runs stress tests on server from the previous release. That leads to creating wal.bin file on disk. After that upgrade check runs new build with the files from previous run. Therefore we are sure that wal.bin is supported (not broken) in read-and-delete way in new build.

@CheSema
Copy link
Copy Markdown
Member

CheSema commented May 6, 2023

I see, good test tests/integration/test_backward_compatibility/test_in_memory_parts_still_read.py.
It is better than my proposal. Thanks.

@alexey-milovidov alexey-milovidov mentioned this pull request May 8, 2023
Closed
@alexey-milovidov alexey-milovidov merged commit 6ad3bec into master May 8, 2023
@alexey-milovidov alexey-milovidov deleted the deprecate-in-memory-parts branch May 8, 2023 02:38
@kssenii kssenii mentioned this pull request May 17, 2023
Merged
alexey-milovidov added a commit that referenced this pull request May 18, 2023
@alexey-milovidov
Merge pull request #49964 from ClickHouse/kssenii-patch-7
86e1454 
Follow up to #49429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@CheSema CheSema

Labels

pr-backward-incompatible Pull request with backwards incompatible changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MergeTreeWriteAheadLog: Cannot write to finalized buffer when dropping part after failed INSERT

3 participants

@alexey-milovidov @robot-ch-test-poll3 @CheSema