Suport settings for async distributed inserts (#4852)#4936
Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom May 9, 2019
Merged
Suport settings for async distributed inserts (#4852)#4936alexey-milovidov merged 2 commits intoClickHouse:masterfrom
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
Conversation
alexey-milovidov
added
can be tested
pr-improvement
Member
There was a problem hiding this comment.
Is it backward compatible?
alexey-milovidov
changed the title
TCeason
force-pushed
the
feature/support_settings_for_async
branch
from
50458ae to
7e7f05d
Compare
There is no hash operation on Settings. Because it is less valuable for hash operations. And I dont know how to write a testcase.
TCeason
force-pushed
the
feature/support_settings_for_async
branch
from
d2c23f3 to
b394a79
Compare
Member
|
Ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no hash operation on Settings. Because it is less valuable for hash operations.
And I dont know how to write a testcase.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
Respect query settings in asynchronous INSERTs into Distributed tables.
Detailed description (optional):
#4852