Skip to content

Fix join_use_nulls in analyzer#49359

Merged
vdimir merged 5 commits intomasterfrom
vdimir/matcher_join_use_nulls
May 31, 2023
Merged

Fix join_use_nulls in analyzer#49359
vdimir merged 5 commits intomasterfrom
vdimir/matcher_join_use_nulls

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented May 1, 2023 •
edited by alexey-milovidov
Loading

Changelog category (leave one):

  • Not for changelog

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Fix join_use_nulls in analyzer.

Matches were not handled. Also column is not nullable if it was resolved from both tables

SELECT a FROM ( SELECT * FROM (SELECT 1 AS a) t1 FULL JOIN (SELECT 1 AS key) t2 ON t1.a = t2.key;
SELECT a FROM ( SELECT a FROM (SELECT 1 AS a) t1 FULL JOIN (SELECT 1 AS a) t2 ON t1.a = t2.a;

@kitaisreal

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-bugfix Pull request with bugfix, not backported by default label May 1, 2023
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented May 1, 2023 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit 783b546 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🔴 failure
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@vdimir vdimir mentioned this pull request May 5, 2023
Closed
@alexey-milovidov alexey-milovidov removed the pr-bugfix Pull request with bugfix, not backported by default label May 6, 2023
@vdimir vdimir mentioned this pull request May 8, 2023
Merged
1 task
@vdimir vdimir force-pushed the vdimir/matcher_join_use_nulls branch from 1786461 to 8d901eb Compare May 9, 2023 16:43
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 9, 2023
@vdimir vdimir requested a review from novikd May 10, 2023 11:23
vdimir added a commit that referenced this pull request May 10, 2023
@vdimir
Cherry-pick PR 'Fix join_use_nulls in analyzer' #49359
1e50db0
novikd
novikd reviewed May 11, 2023
View reviewed changes
src/Analyzer/Passes/QueryAnalysisPass.cpp

static std::optional<JoinTableSide> getColumnSideFromJoinTree(QueryTreeNodePtr & resolved_identifier, const JoinNode & join_node)
{
const auto * column_src = resolved_identifier->as<ColumnNode &>().getColumnSource().get();
Copy link
Copy Markdown
Member

@novikd novikd May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be a function node?

Copy link
Copy Markdown
Member Author

@vdimir vdimir May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can be SELECT ta.t.* FROM ta FULL JOIN tb USING (t.t.t); where ta.t is nested.

I added handling to this function in this PR , but will add test in #49703 , because without tat fix it will be fail in other place

@vdimir vdimir mentioned this pull request May 15, 2023
Merged
2 tasks
@vdimir vdimir requested a review from novikd May 15, 2023 16:48
@vdimir vdimir force-pushed the vdimir/matcher_join_use_nulls branch from 8208a27 to 473cb04 Compare May 15, 2023 16:52
novikd
novikd reviewed May 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@novikd novikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM

src/Analyzer/Passes/QueryAnalysisPass.cpp
Comment on lines +4062 to +4070
const auto * nearest_query_scope = scope.getNearestQueryScope();
const QueryNode * nearest_scope_query_node = nearest_query_scope ? nearest_query_scope->scope_node->as<QueryNode>() : nullptr;
const QueryTreeNodePtr & nearest_scope_join_tree = nearest_scope_query_node ? nearest_scope_query_node->getJoinTree() : nullptr;
const JoinNode * nearest_scope_join_node = nearest_scope_join_tree ? nearest_scope_join_tree->as<JoinNode>() : nullptr;
Copy link
Copy Markdown
Member

@novikd novikd May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't understand what happened here. Please add a comment.

novikd
novikd reviewed May 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@novikd novikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM

@vdimir vdimir force-pushed the vdimir/matcher_join_use_nulls branch 2 times, most recently from d6e8f48 to 783b546 Compare May 30, 2023 16:49
@vdimir vdimir merged commit 9e4eafc into master May 31, 2023
@vdimir vdimir deleted the vdimir/matcher_join_use_nulls branch May 31, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@novikd novikd novikd left review comments

Assignees

@novikd novikd

@kitaisreal kitaisreal

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vdimir @robot-ch-test-poll1 @novikd @alexey-milovidov @kitaisreal