Skip to content

Streaming Data Import From S3#49086

Merged
kssenii merged 50 commits intoClickHouse:masterfrom
s-kat:s3queue
Aug 2, 2023
Merged

Streaming Data Import From S3#49086
kssenii merged 50 commits intoClickHouse:masterfrom
s-kat:s3queue

Conversation

@s-kat
Copy link
Copy Markdown
Contributor

@s-kat s-kat commented Apr 24, 2023 •
edited by kssenii
Loading

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add new table engine S3Queue for streaming data import from s3. Closes #37012.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@s-kat
wip
b412314 
add zookeeper

add settings
@kssenii kssenii self-assigned this Apr 24, 2023
@kssenii kssenii added the can be tested Allows running workflows for external contributors label Apr 24, 2023
@alexey-milovidov alexey-milovidov marked this pull request as draft April 24, 2023 13:33
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Apr 24, 2023

Waiting for the code to be uncommented :)

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-feature Pull request with new product feature label Apr 28, 2023
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented Apr 29, 2023 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit 8893670 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Docs CheckBuilds and tests the documentation🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@kssenii
Copy link
Copy Markdown
Member

kssenii commented May 1, 2023 •
edited
Loading

please don't forget about adding tests :)
see tests/integration folder.
example how to run the tests:
cd tests/integration
using pytest: pytest -ss test_storage_s3/test.py::test_select -vv -xx
using runner: ./runner "-x -ss test_storage_s3/test.py::test_select -v -vv"
if you use runner, there is no need to install anything, if you use pytest then you need to install this https://github.com/ClickHouse/ClickHouse/blob/master/docker/test/integration/runner/Dockerfile#L63-L99

kssenii
kssenii reviewed May 22, 2023
View reviewed changes
kssenii
kssenii reviewed May 31, 2023
View reviewed changes
kssenii
kssenii approved these changes Aug 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@kssenii kssenii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have some todo, will make in follow-up PR.

@kssenii kssenii merged commit b2d2a29 into ClickHouse:master Aug 2, 2023
@tavplubix
Copy link
Copy Markdown
Member

tavplubix commented Aug 8, 2023

@s-kat, the new test is flaky, please take a look: https://s3.amazonaws.com/clickhouse-test-reports/0/066dd8a2e8d1e5fb5f01950b5ece3855aac6b3e1/integration_tests__release__[4_4].html

Copilot AI mentioned this pull request Dec 8, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels

can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Streaming Data Import From S3

6 participants

@s-kat @alexey-milovidov @robot-clickhouse @kssenii @tavplubix @robot-ch-test-poll3