Fix skip_unavailable_shards in case of unavailable hosts#48771
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Apr 15, 2023
Merged
Fix skip_unavailable_shards in case of unavailable hosts#48771alexey-milovidov merged 1 commit intoClickHouse:masterfrom
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Conversation
robot-ch-test-poll
added
the
pr-bugfix
azat
force-pushed
the
fix-skip_unavailable_shards
branch
2 times, most recently
from
c073fee to
3d61a32
Compare
In ClickHouse#26658 only one excessive connect had been removed, but due to RemoteQueryExecutor will execute query again in read(), there is one more, fix this by correctly mark connection in sendQuery() But note, that there still will be excessive connections due to separate connections for obtaining structure. Follow-up for: ClickHouse#26658 Fixes: ClickHouse#48728 Signed-off-by: Azat Khuzhin <[email protected]>
azat
force-pushed
the
fix-skip_unavailable_shards
branch
from
3d61a32 to
9f694a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix skip_unavailable_shards in case of unavailable hosts
In #26658 only one excessive connect had been removed, but due to RemoteQueryExecutor will execute query again in read(), there is one more, fix this by correctly mark connection in sendQuery()
But note, that there still will be excessive connections due to separate connections for obtaining structure.
Follow-up for: #26658
Fixes: #48728 (cc @SaltTan @den-crane )