Remove lock for duplicated parts UUIDs (allow_experimental_query_deduplication=1)#48670
Merged
Avogar merged 1 commit intoClickHouse:masterfrom Apr 12, 2023
Merged
Conversation
…plication=1) It looks redundant, since sendQuery() cannot be executed in parallel with processPacket() (hence RemoteQueryExecutor::setPartUUIDs()) This likely will fix the lock-order-inversion in RemoteQueryExecutor, since I think it is false-positive. Fixes: ClickHouse#48534 Signed-off-by: Azat Khuzhin <[email protected]>
robot-ch-test-poll2
added
the
pr-not-for-changelog
Avogar
approved these changes
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
It looks redundant, since
sendQuery()cannot be executed in parallel withprocessPacket()(henceRemoteQueryExecutor::setPartUUIDs())This likely will fix the lock-order-inversion in
RemoteQueryExecutor, since I think it is false-positive.Fixes: #48534
Follow-up for: #17348 (cc @xjewer)