Skip to content

Update sort desc in ReadFromMergeTree after applying PREWHERE info#48669

Merged
KochetovNicolai merged 17 commits intomasterfrom
prewhere-optimization-update-sort-desc
Jul 26, 2023
Merged

Update sort desc in ReadFromMergeTree after applying PREWHERE info#48669
KochetovNicolai merged 17 commits intomasterfrom
prewhere-optimization-update-sort-desc

Conversation

@devcrafter
Copy link
Copy Markdown
Member

@devcrafter devcrafter commented Apr 11, 2023 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Related to new analyzer #42648
There are 2 issues:
(1) move_to_prewhere optimization updates ReadFromMergeTree output data stream w/o updating the data stream sorting properties
(2) after the output data stream is updated, the header contains fully qualified column names which are inconsistent with column-names from storage. Therefore, the correct sort description cannot be deduced.

Solution:
The PR updates the sorting description by deducing original header at first and then trying to match table sorting key with the original header

Example from 02317_distinct_in_order_optimization_explain.sh, with optimize_move_to_prewhere = true

EXPLAIN sorting = 1, header = 1
SELECT
    b,
    a
FROM distinct_in_order_explain
WHERE a > 0

┌─explain───────────────────────────────────────────────────┐
│ Expression ((Project names + Projection))                 │
│ Header: b Int32                                           │
│         a Int32                                           │
│ Sorting (None)                                            │
│   Expression (Change column names to column identifiers)  │
│   Header: default.distinct_in_order_explain.b_0 Int32     │
│           default.distinct_in_order_explain.a_1 Int32     │
│   Sorting (None)                                          │
│     ReadFromMergeTree (default.distinct_in_order_explain) │
│     Header: default.distinct_in_order_explain.a_1 Int32   │
│             b Int32                                       │
│     Sorting (None)                                        │
└───────────────────────────────────────────────────────────┘

@devcrafter devcrafter marked this pull request as draft April 11, 2023 17:57
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 11, 2023
@devcrafter devcrafter mentioned this pull request May 5, 2023
Closed
@devcrafter devcrafter added the do not test disable testing on pull request label Jun 13, 2023
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented Jun 13, 2023 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit a48960b with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🔴 failure

@devcrafter devcrafter removed the do not test disable testing on pull request label Jun 13, 2023
@devcrafter devcrafter added the do not test disable testing on pull request label Jul 7, 2023
@devcrafter devcrafter removed the do not test disable testing on pull request label Jul 7, 2023
@devcrafter devcrafter marked this pull request as ready for review July 14, 2023 12:31
@devcrafter
Copy link
Copy Markdown
Member Author

devcrafter commented Jul 16, 2023

S3_ERROR No such key thrown - https://s3.amazonaws.com/clickhouse-test-reports/48669/8f3469e7ad623b34c6272ba7c0cd132107034481/upgrade_check__debug_.html
Known as #48474

@KochetovNicolai KochetovNicolai self-assigned this Jul 26, 2023
@KochetovNicolai KochetovNicolai merged commit a4a8c73 into master Jul 26, 2023
@KochetovNicolai KochetovNicolai deleted the prewhere-optimization-update-sort-desc branch July 26, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KochetovNicolai KochetovNicolai KochetovNicolai approved these changes

Assignees

@KochetovNicolai KochetovNicolai

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devcrafter @robot-clickhouse @KochetovNicolai @robot-ch-test-poll2