Const context for insert interpreter#4852
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Mar 29, 2019
Merged
Conversation
alexey-milovidov
approved these changes
Mar 29, 2019
TCeason
added a commit
to TCeason/ClickHouse
that referenced
this pull request
Apr 29, 2019
There is no hash operation on Settings. Because it is less valuable for hash operations. And I dont know how to write a testcase.
alexey-milovidov
added a commit
that referenced
this pull request
May 9, 2019
Suport settings for async distributed inserts (#4852)
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Dec 4, 2019
This extras includes: - server revision - query settings - query Otherwise the code can try to interpret data, and got for instance std::length_error exception, which is not catched (to mark the part as broken). Also this will protect from the corruptions on disk. And add a simple test, since dbms/tests/integration/test_insert_into_distributed too complex. Also simplify the code by using readStringBinary() over readVarUInt()+b.readStrict() (this also gains additional checks that string is not bigger then 1GB). Refs: ClickHouse#4852 (8ef7f35) v2: avoid ABI breakage (suggested by @vitlibar) v3: minor code fixes (suggested by @vitlibar) and as a consequence clang-8 build fix v4: drop DBMS_MIN_REVISION_WITH_EXTRAS_CHECKSUM_IN_DIST_BATCH and also revert some renames to make the patch cleaner
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
May 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category (leave one):
Detailed description:
That's the first step, support for distributed engine async write with settings