Skip to content

Cherry pick #47246 to 23.2: Change the behavior of formatter %M in function formatDateTime() from minutes to month name#48457

Merged
robot-clickhouse merged 1 commit intobackport/23.2/47246from
cherrypick/23.2/ce2692ba79a73728d6ae3728016a0f8822aff660
Apr 12, 2023
Merged

Cherry pick #47246 to 23.2: Change the behavior of formatter %M in function formatDateTime() from minutes to month name#48457
robot-clickhouse merged 1 commit intobackport/23.2/47246from
cherrypick/23.2/ce2692ba79a73728d6ae3728016a0f8822aff660

Conversation

@robot-ch-test-poll2
Copy link
Copy Markdown
Contributor

Original pull-request #47246

This pull-request is a first step of an automated backporting.
It contains changes like after calling a local command git cherry-pick.
If you intend to continue backporting this changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.

The check results does not matter at this step - you can safely ignore them.

Note

This pull-request will be merged automatically as it reaches the mergeable state, do not merge it manually.

If the PR was closed and then reopened

If it stuck, check #47246 for pr-backports-created and delete it if necessary. Manually merging will do nothing, since pr-backports-created prevents the original PR #47246 from being processed.

@robot-ch-test-poll2 robot-ch-test-poll2 added pr-cherrypick Cherry-pick of merge-commit before backporting. Do not use manually - automated use only! do not test disable testing on pull request labels Apr 6, 2023
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

Dear @antonio2368, @rschu1ze, the PR is not updated for 1d0h58m7s. Please, either resolve the conflicts, or close it to finish the backport process of #47246

@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

Dear @antonio2368, @rschu1ze, the PR is not updated for 1d0h59m43s. Please, either resolve the conflicts, or close it to finish the backport process of #47246

@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

Dear @antonio2368, @rschu1ze, the PR is not updated for 1d0h1m53s. Please, either resolve the conflicts, or close it to finish the backport process of #47246

@robot-clickhouse
Copy link
Copy Markdown
Member

Dear @antonio2368, @rschu1ze, the PR is not updated for 1d0h58m15s. Please, either resolve the conflicts, or close it to finish the backport process of #47246

@rschu1ze
Copy link
Copy Markdown
Member

rschu1ze commented Apr 11, 2023

Sorry for not updating this PR for "1d0h58m15s" 😉

v23.2 is vulnerable of #47291 and should receive this fix. The problem is that there are far too many conflicts to continue with this autogenerated PR (the code was refactored heavily in master ...). I'll do the backport manually in #48631

@rschu1ze rschu1ze closed this Apr 11, 2023
@rschu1ze rschu1ze reopened this Apr 12, 2023
@rschu1ze rschu1ze closed this Apr 12, 2023
@rschu1ze rschu1ze reopened this Apr 12, 2023
@rschu1ze rschu1ze force-pushed the cherrypick/23.2/ce2692ba79a73728d6ae3728016a0f8822aff660 branch from c473c63 to 53947c6 Compare April 12, 2023 11:06
@Felixoid
Copy link
Copy Markdown
Member

don't forget about the note
image

@rschu1ze
Copy link
Copy Markdown
Member

Removed label pr-backports-created from #47246. Let's see what happens 😄

@robot-clickhouse robot-clickhouse merged this pull request into backport/23.2/47246 Apr 12, 2023
@robot-clickhouse robot-clickhouse deleted the cherrypick/23.2/ce2692ba79a73728d6ae3728016a0f8822aff660 branch April 12, 2023 13:10
@Felixoid
Copy link
Copy Markdown
Member

im

It's merged!

@rschu1ze
Copy link
Copy Markdown
Member

^^

ee43ce9b4e208ab39d860699fa61ca1e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not test disable testing on pull request pr-cherrypick Cherry-pick of merge-commit before backporting. Do not use manually - automated use only!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants