Fix possible flakiness of lightweight delete tests (due to index granularity randomization)#48413
Merged
davenger merged 3 commits intoClickHouse:masterfrom Apr 5, 2023
Merged
Conversation
Signed-off-by: Azat Khuzhin <[email protected]>
Member
|
Maybe lets use some fixed but non-standard values for index granularity, like 6000 in one test, 7000 in the other and 10000 in the third one? |
alexey-milovidov
approved these changes
Apr 5, 2023
Member
|
I think it's good enough. |
Member
Author
Sure, I'm ok with both, but does it makes the difference here? Or just to have something non standard? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI: https://s3.amazonaws.com/clickhouse-test-reports/48242/c8da660d96bea153fa0c1dc8fbdb4a560e139a56/stateless_tests__debug__[4/5].html
Changelog category (leave one):
Cc: @davenger