Skip to content

Fix possible flakiness of lightweight delete tests (due to index granularity randomization)#48413

Merged
davenger merged 3 commits intoClickHouse:masterfrom
azat:tests/02352_lightweight_delete
Apr 5, 2023
Merged

Fix possible flakiness of lightweight delete tests (due to index granularity randomization)#48413
davenger merged 3 commits intoClickHouse:masterfrom
azat:tests/02352_lightweight_delete

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Apr 5, 2023

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 5, 2023
@azat azat changed the title Fix 02352_lightweight_delete flakiness (due to index granularity randomization) Fix possible flakiness of lightweight delete tests (due to index granularity randomization) Apr 5, 2023
@davenger davenger self-assigned this Apr 5, 2023
@davenger
Copy link
Copy Markdown
Member

davenger commented Apr 5, 2023

Maybe lets use some fixed but non-standard values for index granularity, like 6000 in one test, 7000 in the other and 10000 in the third one?

@alexey-milovidov
Copy link
Copy Markdown
Member

I think it's good enough.

@davenger davenger merged commit 0ebfdbd into ClickHouse:master Apr 5, 2023
@azat azat deleted the tests/02352_lightweight_delete branch April 5, 2023 19:22
@azat
Copy link
Copy Markdown
Member Author

azat commented Apr 5, 2023

Maybe lets use some fixed but non-standard values for index granularity, like 6000 in one test, 7000 in the other and 10000 in the third one?

Sure, I'm ok with both, but does it makes the difference here? Or just to have something non standard?
There are other tests, that has smaller tables, that will be randomized, so I guess this should be enough:

$ gg -i 'create table [^ (]*' tests/queries/0_stateless/*lightweight*delete* | grep -v index_granularity | grep -i -o 'create table [^ (]*'
CREATE TABLE merge_table_standard_delete
create table t_light
CREATE TABLE t_proj
CREATE TABLE merge_table_standard_delete
CREATE TABLE merge_table_standard_delete
create table t_light
CREATE TABLE replicated_table_r1
CREATE TABLE replicated_table_r2
CREATE TABLE t_light_r1
CREATE TABLE t_light_r2
CREATE TABLE t_light_sync_r1
CREATE TABLE t_light_sync_r2
CREATE TABLE lwd_test
create table t_row_exists
create table t_row_exists
create table t_row_exists
create table t_row_exists
CREATE TABLE url_na_log
CREATE TABLE lwd_test_02521
CREATE TABLE t1_local

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants