Find big allocations without memory limits checks #48401
Merged
Conversation
robot-ch-test-poll1
added
the
pr-not-for-changelog
novikd
approved these changes
Apr 4, 2023
alexey-milovidov
approved these changes
Apr 5, 2023
azat
reviewed
Apr 5, 2023
|
|
||
| MemoryTrackerBlockerInThread blocker; | ||
| LOG_TRACE(&Poco::Logger::get("MemoryTracker"), "Too big allocation ({} bytes) without checking memory limits, " | ||
| "it may lead to OOM. Stack trace: {}", size, StackTrace().toString()); |
Member
There was a problem hiding this comment.
Interesting idea! Maybe it also worth to add a check to {stateless/stress}/run.sh for this pattern?
Member
Author
There was a problem hiding this comment.
We should fix known issues first:
rg -Faz "Too big allocation" clickhouse-server.log.zst | wc
1484 46004 462441
Member
Author
|
Integration tests (asan) [4/6] - #45435 |
This was referenced May 3, 2023
This was referenced Jul 7, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
About big allocations and OOMs: #48178 (comment)
Also it fixes
00002_log_and_exception_messages_formatting: https://s3.amazonaws.com/clickhouse-test-reports/0/d0ba1e76bfdef462ae5fd7b652105b4abf780251/stateless_tests__release_.html(the test has found non-informative exception messages added in #43858 (comment), but it was impossible to understand from the test output, let's improve it)
Fixes #48441