Skip to content

Fix test_backup_all#48400

Merged
alexey-milovidov merged 2 commits intomasterfrom
vitlibar-fix-test-backup-all
Apr 5, 2023
Merged

Fix test_backup_all#48400
alexey-milovidov merged 2 commits intomasterfrom
vitlibar-fix-test-backup-all

Conversation

@vitlibar
Copy link
Copy Markdown
Member

@vitlibar vitlibar commented Apr 4, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fix test_backup_restore_new/test.py::test_backup_all

)
.rstrip("\n")
.split("\n")
)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to convert a TSV result from ClickHouse to a list of lines in Python.
But it appears Python calculates ''.split("\n") as [''] (a list with one empty string) somehow, not an empty list. Which is not what I want. splitlines() suits this case better.

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 4, 2023
@alexey-milovidov alexey-milovidov self-assigned this Apr 4, 2023
@alexey-milovidov alexey-milovidov merged commit 32c696e into master Apr 5, 2023
@alexey-milovidov alexey-milovidov deleted the vitlibar-fix-test-backup-all branch April 5, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants