More options for SYSTEM SYNC REPLICA#48085
Merged
Conversation
antonio2368
approved these changes
Mar 28, 2023
src/Parsers/SyncReplicaMode.h
Outdated
|
|
||
| namespace DB | ||
| { | ||
| enum class SyncReplicaMode |
Member
There was a problem hiding this comment.
Suggested change
| enum class SyncReplicaMode | |
| enum class SyncReplicaMode : uint8_t |
Comment on lines
+2486
to
+2487
| bool is_lightweight = entry->type == LogEntry::GET_PART || entry->type == LogEntry::ATTACH_PART | ||
| || entry->type == LogEntry::DROP_RANGE || entry->type == LogEntry::REPLACE_RANGE || entry->type == LogEntry::DROP_PART; |
Member
There was a problem hiding this comment.
I would prefer creating static constexpr std::array and doing std::any_of because this is huge.
But I'm fine either way.
Member
Author
|
Integration tests (release) [4/4] - test_version_update_after_mutation - ORDER BY is missing, will add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added
LIGHTWEIGHTandPULLmodifiers forSYSTEM SYNC REPLICAquery.LIGHTWEIGHTversion waits for fetches and drop-ranges only (merges and mutations are ignored).PULLversion pulls new entries from ZooKeeper and does not wait for them. Fixes #47794