Skip to content

Fix tsan error lock-order-inversion#47953

Merged
alexey-milovidov merged 5 commits intomasterfrom
Avogar-patch-2
Mar 27, 2023
Merged

Fix tsan error lock-order-inversion#47953
alexey-milovidov merged 5 commits intomasterfrom
Avogar-patch-2

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Mar 23, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Closes #47460

@Avogar Avogar added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Mar 23, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 23, 2023
@KochetovNicolai KochetovNicolai self-assigned this Mar 23, 2023
@tavplubix
Copy link
Copy Markdown
Member

Stateless tests (tsan, s3 storage) [3/5] - there's a data race between QueryStatus::removePipelineExecutor and QueryStatus::ExecutorHolder::remove(): https://pastila.nl/?0038f02c/9990ad75e485129914bf0bd050aa20c5

@tavplubix tavplubix marked this pull request as draft March 24, 2023 13:44
@Avogar Avogar marked this pull request as ready for review March 25, 2023 12:31
@Avogar Avogar requested a review from KochetovNicolai March 25, 2023 12:31
@alexey-milovidov alexey-milovidov removed the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Mar 26, 2023
@tavplubix tavplubix added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Mar 27, 2023
@tavplubix
Copy link
Copy Markdown
Member

@alexey-milovidov, see #47460 (comment), that's why it must be backported

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Mar 27, 2023
robot-ch-test-poll3 added a commit that referenced this pull request Mar 28, 2023
Backport #47953 to 23.2: Fix tsan error lock-order-inversion
robot-ch-test-poll1 added a commit that referenced this pull request Mar 28, 2023
Backport #47953 to 22.8: Fix tsan error lock-order-inversion
Avogar added a commit that referenced this pull request Mar 28, 2023
Backport #47953 to 23.1: Fix tsan error lock-order-inversion
Avogar added a commit that referenced this pull request Mar 28, 2023
Backport #47953 to 22.12: Fix tsan error lock-order-inversion
Avogar added a commit that referenced this pull request Mar 28, 2023
Backport #47953 to 22.3: Fix tsan error lock-order-inversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lock order inversion: onCancel

6 participants