Skip to content

Revert "Add sanity checks for writing number in variable length format"#47850

Merged
rschu1ze merged 1 commit intomasterfrom
revert-47608-varuint
Mar 21, 2023
Merged

Revert "Add sanity checks for writing number in variable length format"#47850
rschu1ze merged 1 commit intomasterfrom
revert-47608-varuint

Conversation

@rschu1ze rschu1ze merged commit 15ac561 into master Mar 21, 2023
@rschu1ze rschu1ze deleted the revert-47608-varuint branch March 21, 2023 13:26
@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Mar 25, 2023

https://s3.amazonaws.com/clickhouse-test-reports/0/a9bcd022d5f4a5be530595dbfae3ed177b5c1972/fuzzer_astfuzzermsan/report.html

@azat I reverted the PR ... I think the problem is that the generated query reads 9 quintillion rows (9223372036854775807 == VAR_UINT_MAX). Not realistic for sure, but instead of disallowing this in the AST fuzzer it would be better to make the code more robust. What about doing a sanity check a la writeVarUInt(written_rows > VARUINT_MAX : 0 : written_rows, out); in ProgressValues::write()?

@azat
Copy link
Copy Markdown
Member

azat commented Mar 29, 2023

I reverted the PR ... I think the problem is that the generated query reads 9 quintillion rows (9223372036854775807 == VAR_UINT_MAX). Not realistic for sure, but instead of disallowing this in the AST fuzzer it would be better to make the code more robust. What about doing a sanity check a la writeVarUInt(written_rows > VARUINT_MAX : 0 : written_rows, out); in ProgressValues::write()?

Yep, makes total sense - #48154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants