Revert "Add sanity checks for writing number in variable length format"#47850
Revert "Add sanity checks for writing number in variable length format"#47850
Conversation
|
@azat I reverted the PR ... I think the problem is that the generated query reads 9 quintillion rows (9223372036854775807 == VAR_UINT_MAX). Not realistic for sure, but instead of disallowing this in the AST fuzzer it would be better to make the code more robust. What about doing a sanity check a la |
Yep, makes total sense - #48154 |
The AST fuzzer managed to trigger the new
assert... reverting for nowhttps://play.clickhouse.com/play?user=play#U0VMRUNUIGNoZWNrX25hbWUsIHRlc3RfbmFtZSwgcmVwb3J0X3VybApGUk9NIGNoZWNrcwpXSEVSRSBjaGVja19uYW1lIExJS0UgJ0FTVCBmdXp6ZXIlJwogICAgQU5EIGNoZWNrX3N0YXJ0X3RpbWUgPj0gbm93KCkgLSBJTlRFUlZBTCAyNCBIT1VSCiAgICBBTkQgcHVsbF9yZXF1ZXN0X251bWJlciA9IDAKICAgIEFORCB0ZXN0X3N0YXR1cyAhPSAnU0tJUFBFRCcKICAgIEFORCB0ZXN0X3N0YXR1cyBMSUtFICdGJScKICAgIEFORCBjaGVja19zdGF0dXMgIT0gJ3N1Y2Nlc3MnCk9SREVSIEJZIGNoZWNrX25hbWUsIHRlc3RfbmFtZSwgY2hlY2tfc3RhcnRfdGltZQ==