Only valid Reviews.STATES overwrite existing reviews#47789
Merged
robot-clickhouse-ci-1 merged 2 commits intomasterfrom Mar 20, 2023
Merged
Only valid Reviews.STATES overwrite existing reviews#47789robot-clickhouse-ci-1 merged 2 commits intomasterfrom
robot-clickhouse-ci-1 merged 2 commits intomasterfrom
Conversation
robot-clickhouse-ci-1
added
the
pr-not-for-changelog
tavplubix
approved these changes
Mar 20, 2023
tests/ci/merge_pr.py
Outdated
Member
|
one more comment |
Felixoid
force-pushed
the
proper-review-states
branch
from
0d41618 to
5eacb6b
Compare
Member
Author
|
Much appreciated, there are other fixes |
tavplubix
approved these changes
Mar 20, 2023
tavplubix
reviewed
Mar 20, 2023
| continue | ||
|
|
||
| if r.submitted_at < self.reviews[user].submitted_at: | ||
| # Do not process other statuses than STATES for existing user keys |
Member
Author
|
Looks better now, thanks! |
Felixoid
added
the
pr-must-backport
robot-clickhouse
added a commit
that referenced
this pull request
Mar 21, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Mar 21, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Mar 21, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Mar 21, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Mar 21, 2023
robot-clickhouse-ci-1
added
the
pr-backports-created
Felixoid
added a commit
that referenced
this pull request
Mar 21, 2023
Backport #47789 to 22.3: Only valid Reviews.STATES overwrite existing reviews
Felixoid
added a commit
that referenced
this pull request
Mar 21, 2023
Backport #47789 to 22.8: Only valid Reviews.STATES overwrite existing reviews
Felixoid
added a commit
that referenced
this pull request
Mar 21, 2023
Backport #47789 to 22.12: Only valid Reviews.STATES overwrite existing reviews
Felixoid
added a commit
that referenced
this pull request
Mar 21, 2023
Backport #47789 to 23.1: Only valid Reviews.STATES overwrite existing reviews
Felixoid
added a commit
that referenced
this pull request
Mar 21, 2023
Backport #47789 to 23.2: Only valid Reviews.STATES overwrite existing reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix unreliable merge_pr part.