Skip to content

Added a new column _block_number#47532

Merged
SmitaRKulkarni merged 83 commits intomasterfrom
44532_Persistent_virtual_column__block_number
Sep 20, 2023
Merged

Added a new column _block_number#47532
SmitaRKulkarni merged 83 commits intomasterfrom
44532_Persistent_virtual_column__block_number

Conversation

@SmitaRKulkarni
Copy link
Copy Markdown
Member

@SmitaRKulkarni SmitaRKulkarni commented Mar 13, 2023 •
edited
Loading

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added a new column _block_number resolves #44532

Implementation:

  • _block_number column is not persisted for new blocks.
  • For merges if the value is not set then its taken from part info.
  • Added MergeTreeSetting allow_experimental_block_number_column, only when this is enabled column is persisted.
  • If not persisted, querying this column will return the min block number of part.
    Testing:
  • Added a test for _block_number column in 02668_column_block_number.sql

@SmitaRKulkarni
Added a new column _block_number
14fa247 
Implementation:
* _block_number column is not persisted for new blocks.
* For merges if the value is not set then its taken from part info.
Testing:
* Added a test for _block_number column in 02668_column_block_number.sql
@SmitaRKulkarni SmitaRKulkarni marked this pull request as draft March 13, 2023 13:15
@rschu1ze rschu1ze self-assigned this Mar 16, 2023
rschu1ze
rschu1ze reviewed Mar 16, 2023
View reviewed changes
@SmitaRKulkarni
Copy link
Copy Markdown
Member Author

SmitaRKulkarni commented Mar 21, 2023

@rschu1ze : Thanks for the review. I will look into the comments.
This PR is still in progress, I will fix the failing tests (most of the because of virtual column change) and update docs too.

rschu1ze
rschu1ze reviewed Mar 27, 2023
View reviewed changes
alesapin
alesapin reviewed Apr 11, 2023
View reviewed changes
@robot-clickhouse robot-clickhouse added the pr-feature Pull request with new product feature label Apr 12, 2023
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented May 2, 2023 •
edited by robot-ch-test-poll3
Loading

This is an automated comment for commit 8c5f391 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs CheckBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

alesapin
alesapin approved these changes Sep 7, 2023
View reviewed changes
SmitaRKulkarni
SmitaRKulkarni commented Sep 8, 2023
View reviewed changes
@SmitaRKulkarni
- Updated with new way of reading MergeTree data
9ae8713 
- Disabled allow_experimental_block_number_column by default and fixed tests accordingly
@SmitaRKulkarni SmitaRKulkarni force-pushed the 44532_Persistent_virtual_column__block_number branch from e9edb49 to 9ae8713 Compare September 18, 2023 16:44
@SmitaRKulkarni SmitaRKulkarni marked this pull request as ready for review September 18, 2023 16:47
@SmitaRKulkarni SmitaRKulkarni merged commit d8adf05 into master Sep 20, 2023
@SmitaRKulkarni SmitaRKulkarni deleted the 44532_Persistent_virtual_column__block_number branch September 20, 2023 09:31
@tavplubix tavplubix mentioned this pull request Nov 1, 2023
Closed
@qoega qoega mentioned this pull request Feb 9, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alesapin alesapin alesapin approved these changes

@rschu1ze rschu1ze Awaiting requested review from rschu1ze

Assignees

@alesapin alesapin

Labels

pr-feature Pull request with new product feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Persistent virtual column _block_number

10 participants

@SmitaRKulkarni @robot-ch-test-poll4 @alesapin @rschu1ze @robot-clickhouse @robot-ch-test-poll @robot-ch-test-poll1 @robot-ch-test-poll3 @robot-clickhouse-ci-1 @robot-clickhouse-ci-2