Skip to content

Add new function generateRandomStructure#47409

Merged
Avogar merged 25 commits intoClickHouse:masterfrom
Avogar:random-structure
Jun 2, 2023
Merged

Add new function generateRandomStructure#47409
Avogar merged 25 commits intoClickHouse:masterfrom
Avogar:random-structure

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Mar 9, 2023 •
edited
Loading

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add new function generateRandomStructure that generates random table structure. It can be used in combination with table function generateRandom.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse robot-clickhouse added the pr-feature Pull request with new product feature label Mar 9, 2023
@Avogar Avogar marked this pull request as draft March 9, 2023 18:30
@Avogar Avogar marked this pull request as ready for review March 9, 2023 20:26
@Avogar Avogar marked this pull request as draft March 9, 2023 20:37
@amosbird
Copy link
Copy Markdown
Collaborator

amosbird commented Mar 10, 2023

Random2 😂

@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented May 11, 2023 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit 58610f1 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Docs CheckBuilds and tests the documentation🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🔴 failure
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@Avogar Avogar marked this pull request as ready for review May 11, 2023 12:02
@Avogar Avogar mentioned this pull request May 11, 2023
Merged
@al13n321 al13n321 self-assigned this May 11, 2023
al13n321
al13n321 requested changes May 11, 2023
View reviewed changes
src/Functions/generateRandomStructure.cpp Outdated
Comment on lines +62 to +64
TypeIndex::Array,
TypeIndex::Tuple,
TypeIndex::Map,
Copy link
Copy Markdown
Member

@al13n321 al13n321 May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun fact: AFAICT, the expected size of the output of generateRandom(generateRandomStructure(), [random seed], max_array_length) is infinite iff max_array_length >= 26 (default is 10). Because it becomes a "St Petersburg lottery" on nesting depth of arrays: as array nesting depth increases, the size would increase faster than the probability would decrease.

More specifically, we'd be in trouble if expected_array_length * probability_of_array + expected_tuple_length * probability_of_tuple > 1. (Capping depth at 32 wouldn't do much because expected_array_length^32 is still huge.)

Not sure if there's a good way to document or check that. Maybe just mention it in a comment somewhere, if this seems correct and useful.

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented May 11, 2023

@al13n321 thanks for review! I rewrote this code several times, so it's cool to have a fresh look (I see some obvious mistakes, that I didn't noticed after code rewrite, feel stupid :)
I will fix it tomorrow or next week.

al13n321
al13n321 reviewed May 12, 2023
View reviewed changes
@Avogar Avogar merged commit f87f98f into ClickHouse:master Jun 2, 2023
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jun 4, 2023

It breaks CI: #50537

@al13n321
Copy link
Copy Markdown
Member

al13n321 commented Jun 4, 2023

Guess my math about St Petersburg lottery (in comment above) was wrong 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@al13n321 al13n321 al13n321 approved these changes

Assignees

@al13n321 al13n321

Labels

pr-feature Pull request with new product feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Avogar @amosbird @robot-clickhouse @alexey-milovidov @al13n321