Skip to content

Change the behavior of formatter %M in function formatDateTime() from minutes to month name#47246

Merged
rschu1ze merged 9 commits intomasterfrom
rs/m
Apr 6, 2023
Merged

Change the behavior of formatter %M in function formatDateTime() from minutes to month name#47246
rschu1ze merged 9 commits intomasterfrom
rs/m

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Mar 4, 2023

With this PR, MySQL format string %M in SQL functions parseDateTime() and formatDateTime() now matches mySQL's behavior which returns the full month name (e.g. February) instead of minutes (e.g. 00-59).

This finishes #46536. Courtesy to @JakeBamrah

As a side effect, this also fixes asan failure #47291 and it's duplicates. Added label 'pr-must-backport' for that reason.

Review note:

  • The PR Includes two cleanup commit which should be reviewed separately
  • The actual changes are much smaller. Changes in formatDateTime() are a bit more complicated as the infrastructure to generate variable-length output was lacking

The fix is technically backward-incompatible (--> setting label "pr-backward-incompatible"), I added a setting to restore the old behavior if wanted. The backports will have the settings configured to the old behavior by default.

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md)

Formatter '%M' in function formatDateTime() now prints the month name instead of the minutes. This makes the behavior consistent with MySQL. The previous behavior can be restored using setting "formatdatetime_parsedatetime_m_is_month_name = 0".

@rschu1ze rschu1ze added the pr-backward-incompatible Pull request with backwards incompatible changes label Mar 4, 2023
@robot-ch-test-poll3 robot-ch-test-poll3 added pr-improvement Pull request with some product improvements and removed pr-backward-incompatible Pull request with backwards incompatible changes labels Mar 4, 2023
@rschu1ze rschu1ze changed the title Rs/m Change the behavior of formatter %M in function formatDateTime() from minutes to month name Mar 4, 2023
@rschu1ze rschu1ze added the pr-backward-incompatible Pull request with backwards incompatible changes label Mar 5, 2023
@robot-ch-test-poll2 robot-ch-test-poll2 removed the pr-backward-incompatible Pull request with backwards incompatible changes label Mar 5, 2023
@rschu1ze rschu1ze force-pushed the rs/m branch 3 times, most recently from 1bcbb25 to de3b88a Compare March 5, 2023 19:08
@rschu1ze

This comment was marked as outdated.

@JakeBamrah
Copy link
Copy Markdown
Contributor

The work looks great! Well done 😊

@rschu1ze

This comment was marked as outdated.

@rschu1ze

This comment was marked as outdated.

@rschu1ze rschu1ze marked this pull request as ready for review March 8, 2023 09:27
@rschu1ze

This comment was marked as outdated.

@rschu1ze rschu1ze added pr-backport Changes, backported to release branch. Do not use manually - automated use only! pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-backward-incompatible Pull request with backwards incompatible changes and removed pr-backport Changes, backported to release branch. Do not use manually - automated use only! labels Apr 5, 2023
@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Apr 5, 2023

The PR should be in a mergeable state now (fingers crossed ...)

@rschu1ze rschu1ze merged commit ce2692b into master Apr 6, 2023
@rschu1ze rschu1ze deleted the rs/m branch April 6, 2023 07:19
robot-clickhouse added a commit that referenced this pull request Apr 6, 2023
…ion formatDateTime() from minutes to month name
rschu1ze added a commit that referenced this pull request Apr 6, 2023
rschu1ze added a commit that referenced this pull request Apr 6, 2023
zhiqiang-hhhh pushed a commit to zhiqiang-hhhh/ClickHouse that referenced this pull request Apr 11, 2023
* Disable debug logging

* Added check for backup/restore when they fail and status is not COMPLETED

* Fixed comment

* find big allocations without limits checks

* Fix usage of is_unbound in FileSegment

* Test WriteBufferToFileSegment with several threads

* Update test.py

* fix bad error messages

* Fix 02579_fill_empty_chunk.sql

* add perf test

* Fix krb5 with openssl

* Add statistical aggregate function kolmogorovSmirnovTest (ClickHouse#48325)

* doc entry for SYSTEM WAIT LOADING PARTS

* make CI slack bot less noisy

* Make remote bandwidth settings server settings

Right now those two settings are applied only at start:
- max_remote_read_network_bandwidth_for_server
- max_remote_write_network_bandwidth_for_server

Signed-off-by: Azat Khuzhin <[email protected]>

* Move some methods for Context into module part

This will be required later, for per-query bandwidth limiting.

Signed-off-by: Azat Khuzhin <[email protected]>

* Add per-query network throttling

Controlled with:
- max_remote_read_network_bandwidth
- max_remote_write_network_bandwidth

Signed-off-by: Azat Khuzhin <[email protected]>

* Add ability to throttle local IO on per-query/server basis

Server settings:
- max_local_read_bandwidth_for_server
- max_local_write_bandwidth_for_server

Query settings:
- max_local_read_bandwidth
- max_local_write_bandwidth

This is the preparation for adding ability to throttle BACKUPs

Signed-off-by: Azat Khuzhin <[email protected]>

* Add ability to throttle BACKUPs on per-server/backup basis

Server settings:
- backup_read_bandwidth_for_server
- backup_write_bandwidth_for_server

Query settings:
- backup_read_bandwidth
- backup_write_bandwidth

Signed-off-by: Azat Khuzhin <[email protected]>

* Keep only one throttler for BACKUPs IO (instead of separate read/write)

There is no need in separate read/write throttling, because you cannot
write faster then read anyway, and plus this makes the code less cleaner

(and also it will allow avoid implementing throttling backups to S3,
since it does not use common S3 writer).

Signed-off-by: Azat Khuzhin <[email protected]>

* Use existing ServerSettings in Context instead of reading it again

Signed-off-by: Azat Khuzhin <[email protected]>

* Do not require proper Poco Application for Context

    $ yes | head | clickhouse-obfuscator --structure 'id String' --seed foo --input-format TSV --output-format TSV
    Poco::Exception. Code: 1000, e.code() = 0, Null pointer: _pInstance in file "/src/ch/clickhouse/base/poco/Util/include/Poco/Util/Application.h", line 446, Stack trace (when copying this message, always include the lines below):

    0. /src/ch/clickhouse/contrib/llvm-project/libcxx/include/exception:134: std::exception::capture() @ 0x15605622 in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    1. /src/ch/clickhouse/contrib/llvm-project/libcxx/include/exception:112: std::exception::exception[abi:v15000]() @ 0x156055ed in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    2. /src/ch/clickhouse/base/poco/Foundation/src/Exception.cpp:27: Poco::Exception::Exception(String const&, int) @ 0x2ebd2d80 in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    3. /src/ch/clickhouse/base/poco/Foundation/src/Exception.cpp:132: Poco::LogicException::LogicException(String const&, int) @ 0x2ebd3667 in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    4. /src/ch/clickhouse/base/poco/Foundation/src/Exception.cpp:134: Poco::NullPointerException::NullPointerException(String const&, int) @ 0x2ebd3da7 in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    5. /src/ch/clickhouse/base/poco/Foundation/src/Bugcheck.cpp:42: Poco::Bugcheck::nullPointer(char const*, char const*, int) @ 0x2ebc5851 in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    6. /src/ch/clickhouse/base/poco/Util/include/Poco/Util/Application.h:446: Poco::Util::Application::instance() @ 0x1ee3e6cd in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    7. /src/ch/clickhouse/src/Interpreters/Context.cpp:358: DB::ContextSharedPart::ContextSharedPart() @ 0x263b0cca in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    8. /src/ch/clickhouse/contrib/llvm-project/libcxx/include/__memory/unique_ptr.h:714: std::__unique_if<DB::ContextSharedPart>::__unique_single std::make_unique[abi:v15000]<DB::ContextSharedPart>() @ 0x26387b6e in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    9. /src/ch/clickhouse/src/Interpreters/Context.cpp:652: DB::Context::createShared() @ 0x26361a3c in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    10. /src/ch/clickhouse/programs/obfuscator/Obfuscator.cpp:1293: mainEntryClickHouseObfuscator(int, char**) @ 0x1ef6eb26 in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    11. /src/ch/clickhouse/programs/main.cpp:481: main @ 0x155e569a in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
    12. ? @ 0x7ffff7dd2790 in ?
    13. __libc_start_main @ 0x7ffff7dd284a in ?
    14. _start @ 0x155e51ae in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
     (version 23.3.1.2537)

Signed-off-by: Azat Khuzhin <[email protected]>

* Ignore deprecated values max_remote_{read,write}_network_bandwidth_for_server

Signed-off-by: Azat Khuzhin <[email protected]>

* Use MAKE_DEPRECATED_BY_SERVER_CONFIG() for deprecated throttle settings

Signed-off-by: Azat Khuzhin <[email protected]>

* Do not throttle S3-S3 backups if native copy is possible

Signed-off-by: Azat Khuzhin <[email protected]>

* Remove knowledge about throttling from IBackupWriter::supportNativeCopy()

Signed-off-by: Azat Khuzhin <[email protected]>

* Remove throttler for IDisk::copyFile()

Signed-off-by: Azat Khuzhin <[email protected]>

* AST Fuzzer: Fix assertion in TopK serialization

Problem:
  https://s3.amazonaws.com/clickhouse-test-reports/0/fa5b2bd4a5b02336bca8837c473a7124f8ecedf2/fuzzer_astfuzzerasan/report.html

The new assertion in the Varint code was introduced with (*). It rejects
values whose serialization cannot be deserialized (and this behavior
cannot be changed due to historical reasons). Such values should be
exceptionally rare in practice but AST fuzzer managers to trigger them.

The fix is similar to (**): Bypass the check by limiting the value to
the maximum allowed value.

(if AST fuzzer triggers finds more violations of the assertion, we might
consider throwing an exception instead)

(*) ClickHouse#48154
(**) https://github.com/ClickHouse/ClickHouse/pull/48154/files#diff-653c0a18dfdaa86262c78dc6b25550add0487f165b4ad053e86f530388f6203a

* Fix 02352_lightweight_delete flakiness (due to index granularity randomization)

CI: https://s3.amazonaws.com/clickhouse-test-reports/48242/c8da660d96bea153fa0c1dc8fbdb4a560e139a56/stateless_tests__debug__[4/5].html
Signed-off-by: Azat Khuzhin <[email protected]>

* Set index granularity settings for other two lightweight delete tests

Signed-off-by: Azat Khuzhin <[email protected]>

* Fix build

* Add max_ prefix for backup_bandwidth settings

Signed-off-by: Azat Khuzhin <[email protected]>

* Fix flaky test_keeper_snapshots

* Do not take lock for shared context in setTempDataOnDisk

* Better

* Update docs/en/interfaces/formats.md

Co-authored-by: Yakov Olkhovskiy <[email protected]>

* Update temp_data_on_disk in shared context

* Move suffix generation code into one function

* Rename old_*_columns to input_*_columns

* avoid race, do not set thread_group.counters.parent from query

* Fix build, pt. II

* Fix tests

* Always communicate with local replica through loopback interface for parallel replicas (ClickHouse#48246)

* Fix special build

* Fix darwin build

* fix

* Add unbound flag to system.filesystem_cache

* Rename Context::getTemporaryVolume to getGlobalTemporaryVolume

* Reduce scope storage_policies_mutex in setTemporaryStoragePolicy

* Don't check dependencies when renaming system tables automatically

* add docs for UNDROP TABLE

* lost a word

* Fix test

* Update 02703_jit_external_aggregation.sh

* Better

* Don't replicate KeeperMap DELETE and TRUNCATE

* PR comments

* Update only affected rows in KV storage

* Fix special build

* Update replication.md

* transfer counters to the query directly

* Override user and password environment variables with client parameters

* Incorporate more review feedback

* Fix stuff

* Yet another fix

* fix test

* Better exception messages from Keeper client

* Add why clickhouse-local overview

* Small documentation follow-up to ClickHouse#47246

* Update 00002_log_and_exception_messages_formatting.sql

* Update 00002_log_and_exception_messages_formatting.reference

* Update CachedOnDiskReadBufferFromFile.cpp

* Add reading step for system zookeeper. Analyze path from filter DAG.

* Fix name

* Fix another test

* Fix deadlock due to debug tracking of memory allocations

Since memory tracker should be blocked globally (by default it is blocked only
for VariableContext::User).

<details>

<summary>stacktrace</summary>

    * thread 11, name = 'Collector', stop reason = trace
        frame 1: 0x00007ffff7e37ea2 libc.so.6`pthread_mutex_lock + 274
        frame 6: 0x000000001ee10298 clickhouse`toStringCached(pointers=0x00007fffedfef068, offset=0, size=45) + 88 at StackTrace.cpp:425
        frame 7: 0x000000001ee1128e clickhouse`StackTrace::toString(this=0x00007fffedfef058) const + 46 at StackTrace.cpp:444
        frame 8: 0x000000001ede58ff clickhouse`(anonymous namespace)::debugLogBigAllocationWithoutCheck(size=25187648) + 479 at MemoryTracker.cpp:98
        frame 9: 0x000000001ede5481 clickhouse`MemoryTracker::allocImpl(this=0x0000000030729e68, size=25187648, throw_if_memory_exceeded=false, query_tracker=0x00007ffff3c22440) + 3937 at MemoryTracker.cpp:352
        frame 10: 0x000000001ede477f clickhouse`MemoryTracker::allocImpl(this=0x00007ffff3c1e530, size=25187648, throw_if_memory_exceeded=false, query_tracker=0x00007ffff3c22440) + 607 at MemoryTracker.cpp:198
        frame 11: 0x000000001ede477f clickhouse`MemoryTracker::allocImpl(this=0x00007ffff3c22440, size=25187648, throw_if_memory_exceeded=false, query_tracker=0x0000000000000000) + 607 at MemoryTracker.cpp:198
        frame 12: 0x000000001ede477f clickhouse`MemoryTracker::allocImpl(this=0x00007fffedff3bf0, size=25187648, throw_if_memory_exceeded=false, query_tracker=0x0000000000000000) + 607 at MemoryTracker.cpp:198
        frame 13: 0x000000001ed6c4c9 clickhouse`CurrentMemoryTracker::allocImpl(size=25165824, throw_if_memory_exceeded=false) + 265 at CurrentMemoryTracker.cpp:58
        frame 14: 0x000000001ed6c6a1 clickhouse`CurrentMemoryTracker::allocNoThrow(size=25165824) + 33 at CurrentMemoryTracker.cpp:91
        frame 15: 0x000000001ed63079 clickhouse`operator new(unsigned long) [inlined] void Memory::trackMemory<>(size=25165824) + 89 at memory.h:177
        frame 16: 0x000000001ed63034 clickhouse`operator new(size=25165824) + 20 at new_delete.cpp:74
        ...
        frame 27: 0x000000001ee15895 clickhouse`DB::(anonymous namespace)::collectSymbols(info=0x00007ffff7062000, (null)=<unavailable>, data_ptr=0x00007fffec2b7000) + 53 at SymbolIndex.cpp:483
        frame 28: 0x000000002e1a5d57 clickhouse`::dl_iterate_phdr(callback=(clickhouse`DB::(anonymous namespace)::collectSymbols(dl_phdr_info*, unsigned long, void*) at SymbolIndex.cpp:480), data=0x00007fffec2b7000)(dl_phdr_info *, size_t, void *), void *) + 183 at phdr_cache.cpp:76
        frame 29: 0x000000001ee15549 clickhouse`DB::SymbolIndex::update(this=0x00007fffec2b7000) + 41 at SymbolIndex.cpp:515
        frame 30: 0x000000001ee1be35 clickhouse`DB::SymbolIndex::SymbolIndex(this=<unavailable>) + 53 at SymbolIndex.h:23
        frame 31: 0x000000001ee17a6c clickhouse`DB::SymbolIndex::instanceImpl() + 108 at SymbolIndex.cpp:555
        frame 32: 0x000000001ee17b4a clickhouse`DB::SymbolIndex::instance() + 10 at SymbolIndex.cpp:561
        frame 33: 0x000000001ee1070f clickhouse`void toStringEveryLineImpl<toStringCached(std::__1::array<void*, 45ul> const&, unsigned long, unsigned long)::$_0>(fatal=false, stack_trace=0x00007fffedff1ef8, callback=0x00007fffedff1ee0)::$_0&&) + 207 at StackTrace.cpp:349
        frame 34: 0x000000001ee1040b clickhouse`toStringCached(pointers=0x00007fffedff2928, offset=0, size=43) + 459 at StackTrace.cpp:436
        frame 35: 0x000000001ee1128e clickhouse`StackTrace::toString(this=0x00007fffedff2918) const + 46 at StackTrace.cpp:444
        frame 36: 0x000000001ede58ff clickhouse`(anonymous namespace)::debugLogBigAllocationWithoutCheck(size=25165824) + 479 at MemoryTracker.cpp:98
        frame 37: 0x000000001ede5481 clickhouse`MemoryTracker::allocImpl(this=0x00007fffedff3bf0, size=25165824, throw_if_memory_exceeded=false, query_tracker=0x0000000000000000) + 3937 at MemoryTracker.cpp:352
        frame 38: 0x000000001ed6c4c9 clickhouse`CurrentMemoryTracker::allocImpl(size=25165824, throw_if_memory_exceeded=false) + 265 at CurrentMemoryTracker.cpp:58
        frame 39: 0x000000001ed6c6a1 clickhouse`CurrentMemoryTracker::allocNoThrow(size=25165824) + 33 at CurrentMemoryTracker.cpp:91
        frame 40: 0x000000001ed63079 clickhouse`operator new(unsigned long) [inlined] void Memory::trackMemory<>(size=25165824) + 89 at memory.h:177
        frame 41: 0x000000001ed63034 clickhouse`operator new(size=25165824) + 20 at new_delete.cpp:74
        ...
        frame 55: 0x0000000025badace clickhouse`DB::WriteBufferFromS3::nextImpl(this=0x00007ffff3c58f00) + 366 at WriteBufferFromS3.cpp:110

</details>

Signed-off-by: Azat Khuzhin <[email protected]>

* Update 00002_log_and_exception_messages_formatting.sql

* Update 00002_log_and_exception_messages_formatting.reference

* fix query cache with sparse columns

* Update docs/en/sql-reference/statements/undrop.md

Co-authored-by: Alexander Tokmakov <[email protected]>

* Update docs/en/sql-reference/statements/undrop.md

Co-authored-by: Alexander Tokmakov <[email protected]>

* Update docs/en/sql-reference/statements/undrop.md

* add note about MV

* Fix bytesSize() of zk SetRequest

* Remove dead code and unused dependencies

* Use std::string_view instead of strlen

* Use std::string::starts_with instead of a roll your own variant

* Reduce memory usage for multiple alter delete mutations.

* Fix equals.

* Update ClickHouse logo

* Mark a function inline

* Change ClickHouse logo to dark mode

* Parallel reading in FROM file()

* Fix header

* Fix test

* Sync replicas after inserts

* Fix nullptr to memcpy

* Use forward declaration of ThreadPool

Signed-off-by: Azat Khuzhin <[email protected]>

* Fix 01548_parallel_parsing_max_memory.sh

* Fix: do not resize pipeline when there is no files to process (globs expands to empty set)

* fix test test_multiple_disks

* Fix bracketed-paste mode messing up password input in client reconnect

* fix a bug in sync replica

* fix REPLACE_RANGE

* Perf test

* suppress a bug in filesystem cache

* Fix 02477_projection_materialize_and_zero_copy flakienss (due to index granularity randomization)

Signed-off-by: Azat Khuzhin <[email protected]>

* Better exception message for ZSTD

* Fix typo in word acquired, in comment for lockForAlter method

* Fix 02293_formats_json_columns

* Fix test which can become flaky due to file() parallelization

* Fix 02286_mysql_dump_input_format

* A try to prevent possible tests flakyness due to file() parallelization

* Remove misleading comment

It is no longer "significant" after `NOEXCEPT_SCOPE` macro rework ClickHouse#39229

* Fix tests: truncate output file on insert

* Add support for {server_uuid} macro

* Add a test

* Update test

* Update 02207_allow_plaintext_and_no_password.sh

* Update formats.md

* bugfix: compare Bits and sizeof(Arithmetic) * 8

* Update tests/queries/0_stateless/02711_server_uuid_macro.sql

Co-authored-by: Nikolay Degterinsky <[email protected]>

* Adopt tests to run in parallel or mark as no-parallel (for flaky check)

* Fix uncaught exception in case of parallel loader for hashed dictionaries

Since ThreadPool::wait() rethrows the first exception (if any):

<details>

<summary>stacktrace</summary>

    2023.04.09 12:53:33.629333 [ 22361 ] {} <Fatal> BaseDaemon: (version 22.13.1.1, build id: 5FB01DCAAFFF19F0A9A61E253567F90685989D2F) (from thread 23032) Terminate called for uncaught exception:
    2023.04.09 12:53:33.630179 [ 23645 ] {} <Fatal> BaseDaemon:
    2023.04.09 12:53:33.630213 [ 23645 ] {} <Fatal> BaseDaemon: Stack trace: 0x7f68b00baccc 0x7f68b006bef2 0x7f68b0056472 0x112a42fe 0x1c17f2a3 0x1c17f238 0xbf4bc3b 0x13961c6d 0x138ee529 0x138ed6bc 0x138dd2f0 0x138dd9c6 0x1571d0dd 0x16197c1f 0x161a231e 0x1619fc93 0x161a51b9 0x11151759 0x1115454e 0x7f68b00b8fd4 0x7f68b013966c
    2023.04.09 12:53:33.630247 [ 23645 ] {} <Fatal> BaseDaemon: 3. ? @ 0x7f68b00baccc in ?
    2023.04.09 12:53:33.630263 [ 23645 ] {} <Fatal> BaseDaemon: 4. gsignal @ 0x7f68b006bef2 in ?
    2023.04.09 12:53:33.630273 [ 23645 ] {} <Fatal> BaseDaemon: 5. abort @ 0x7f68b0056472 in ?
    2023.04.09 12:53:33.648815 [ 23645 ] {} <Fatal> BaseDaemon: 6. ./.build/./src/Daemon/BaseDaemon.cpp:456: terminate_handler() @ 0x112a42fe in /usr/lib/debug/usr/bin/clickhouse.debug
    2023.04.09 12:53:33.651484 [ 23645 ] {} <Fatal> BaseDaemon: 7. ./.build/./contrib/llvm-project/libcxxabi/src/cxa_handlers.cpp:61: std::__terminate(void (*)()) @ 0x1c17f2a3 in /usr/lib/debug/usr/bin/clickhouse.debug
    2023.04.09 12:53:33.654080 [ 23645 ] {} <Fatal> BaseDaemon: 8. ./.build/./contrib/llvm-project/libcxxabi/src/cxa_handlers.cpp:79: std::terminate() @ 0x1c17f238 in /usr/lib/debug/usr/bin/clickhouse.debug
    2023.04.09 12:53:35.025565 [ 23645 ] {} <Fatal> BaseDaemon: 9. ? @ 0xbf4bc3b in /usr/lib/debug/usr/bin/clickhouse.debug
    2023.04.09 12:53:36.495557 [ 23645 ] {} <Fatal> BaseDaemon: 10. DB::ParallelDictionaryLoader<(DB::DictionaryKeyType)0, true, true>::~ParallelDictionaryLoader() @ 0x13961c6d in /usr/lib/debug/usr/bin/clickhouse.debug
    2023.04.09 12:53:37.833142 [ 23645 ] {} <Fatal> BaseDaemon: 11. DB::HashedDictionary<(DB::DictionaryKeyType)0, true, true>::loadData() @ 0x138ee529 in /usr/lib/debug/usr/bin/clickhouse.debug
    2023.04.09 12:53:39.124989 [ 23645 ] {} <Fatal> BaseDaemon: 12. DB::HashedDictionary<(DB::DictionaryKeyType)0, true, true>::HashedDictionary(DB::StorageID const&, DB::DictionaryStructure const&, std::__1::shared_ptr<DB::IDictionarySource>, DB::HashedDictionaryStorageConfiguration const&, std::__1::shared_ptr<DB::Block>) @ 0x138ed6bc in /usr/lib/debug/usr/bin/clickhouse.debug

</details>

Signed-off-by: Azat Khuzhin <[email protected]>

* Simpler way to resize pipeline

* Update CCTZ

* Update deltasumtimestamp.md

* Update deltasumtimestamp.md

* Update deltasumtimestamp.md

* Update deltasumtimestamp.md

* Remove slow test from debug builds

* Fix tests for flaky check

* Add a test

* Better exception messages for unparsed Bool

* Fixup

* Don't use type conversion with String query parameters

* Fix

* Slightly optimize Install

* Fix TSan report in Kerberos

* Update src/Interpreters/ReplaceQueryParameterVisitor.cpp

Co-authored-by: Alexey Milovidov <[email protected]>

* Fixing build

* Docs: Add SETTINGS to executable table function

* Remove superfluous includes of logger_userful.h from headers

Signed-off-by: Azat Khuzhin <[email protected]>

* Update formats.md

Including an Avro example with DESCRIBE url in S3

---------

Signed-off-by: Azat Khuzhin <[email protected]>
Co-authored-by: Igor Nikonov <[email protected]>
Co-authored-by: Smita Kulkarni <[email protected]>
Co-authored-by: Alexander Tokmakov <[email protected]>
Co-authored-by: vdimir <[email protected]>
Co-authored-by: Vitaly Baranov <[email protected]>
Co-authored-by: Dmitry Novik <[email protected]>
Co-authored-by: robot-ch-test-poll <[email protected]>
Co-authored-by: Robert Schulze <[email protected]>
Co-authored-by: Anton Popov <[email protected]>
Co-authored-by: Boris Kuschel <[email protected]>
Co-authored-by: FFFFFFFHHHHHHH <[email protected]>
Co-authored-by: Sergei Trifonov <[email protected]>
Co-authored-by: Rich Raposa <[email protected]>
Co-authored-by: robot-clickhouse-ci-1 <[email protected]>
Co-authored-by: Azat Khuzhin <[email protected]>
Co-authored-by: Antonio Andelic <[email protected]>
Co-authored-by: Antonio Andelic <[email protected]>
Co-authored-by: avogar <[email protected]>
Co-authored-by: Kruglov Pavel <[email protected]>
Co-authored-by: Yakov Olkhovskiy <[email protected]>
Co-authored-by: Sema Checherinda <[email protected]>
Co-authored-by: Nikita Mikhaylov <[email protected]>
Co-authored-by: Raúl Marín <[email protected]>
Co-authored-by: DanRoscigno <[email protected]>
Co-authored-by: kssenii <[email protected]>
Co-authored-by: Alexey Milovidov <[email protected]>
Co-authored-by: Nikita Mikhaylov <[email protected]>
Co-authored-by: Nikolai Kochetov <[email protected]>
Co-authored-by: robot-clickhouse <[email protected]>
Co-authored-by: Alexander Gololobov <[email protected]>
Co-authored-by: Sema Checherinda <[email protected]>
Co-authored-by: Nikolay Degterinsky <[email protected]>
Co-authored-by: robot-ch-test-poll2 <[email protected]>
Co-authored-by: Yakov Olkhovskiy <[email protected]>
Co-authored-by: robot-ch-test-poll1 <[email protected]>
Co-authored-by: Mikhail f. Shiryaev <[email protected]>
Co-authored-by: robot-ch-test-poll3 <[email protected]>
Co-authored-by: Justin de Guzman <[email protected]>
Co-authored-by: Kseniia Sumarokova <[email protected]>
Co-authored-by: Nikolai Kochetov <[email protected]>
Co-authored-by: Alexander Tokmakov <[email protected]>
Co-authored-by: ltrk2 <[email protected]>
Co-authored-by: robot-clickhouse-ci-2 <[email protected]>
Co-authored-by: alesapin <[email protected]>
Co-authored-by: Nikolay Degterinsky <[email protected]>
Co-authored-by: lzydmxy <[email protected]>
Co-authored-by: Michael Kolupaev <[email protected]>
Co-authored-by: Artem Pershin <[email protected]>
Co-authored-by: caipengxiang <[email protected]>
Co-authored-by: Denny Crane <[email protected]>
Co-authored-by: Thom O'Connor <[email protected]>
Co-authored-by: Igor Nikonov <[email protected]>
Co-authored-by: robot-ch-test-poll4 <[email protected]>
rschu1ze added a commit that referenced this pull request Apr 11, 2023
Backport #47246 to 23.3: Change the behavior of formatter %M in function formatDateTime() from minutes to month name
@robot-clickhouse robot-clickhouse added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Apr 11, 2023
@rschu1ze rschu1ze removed the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Apr 12, 2023
robot-clickhouse added a commit that referenced this pull request Apr 12, 2023
…ion formatDateTime() from minutes to month name
@robot-clickhouse robot-clickhouse added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Apr 12, 2023
rschu1ze added a commit that referenced this pull request Apr 13, 2023
Backport #47246 to 23.2: Change the behavior of formatter %M in function formatDateTime() from minutes to month name
@den-crane
Copy link
Copy Markdown
Contributor

I would do

formatdatetime_parsedatetime_m_is_month_name=throw (default)
formatdatetime_parsedatetime_m_is_month_name=mysql_compat
formatdatetime_parsedatetime_m_is_month_name=legacy_compat

@rschu1ze
Copy link
Copy Markdown
Member Author

@den-crane With the benefit of hindsight, I agree. On the other hand, this PR appeared as a backward-incompatible change in the changelog (v23.4, here) and the new behavior is well documented ("Note 1", here). Changing the setting once more would create unnecessary confusion, IMHO. And at some point (1-2 years from now?), we probably might want to get rid of formatdatetime_parsedatetime_m_is_month_name anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backward-incompatible Pull request with backwards incompatible changes pr-improvement Pull request with some product improvements pr-must-backport Pull request should be backported intentionally. Use this label with great care!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants