Skip to content

Backup_Restore_concurrency_check_node#47216

Merged
vitlibar merged 4 commits intomasterfrom
Backup_Restore_concurrency_check_node
Mar 14, 2023
Merged

Backup_Restore_concurrency_check_node#47216
vitlibar merged 4 commits intomasterfrom
Backup_Restore_concurrency_check_node

Conversation

@SmitaRKulkarni
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Bug-fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Updated to use tryGet instead of get for checking stage of backups/restores in concurrency check and updated tests by increasing data size to have a longer backup/restore to ensure the overlap and increased timeout correspondingly.

…stores in concurrency check and updated tests by increasing data size to have a longer backup/restore to ensure the overlap and increased timeout correspondingly.
@SmitaRKulkarni SmitaRKulkarni requested a review from vitlibar March 3, 2023 15:50
@vitlibar vitlibar self-assigned this Mar 13, 2023
@vitlibar vitlibar merged commit 859082c into master Mar 14, 2023
@vitlibar vitlibar deleted the Backup_Restore_concurrency_check_node branch March 14, 2023 12:36
@vitlibar
Copy link
Copy Markdown
Member

The test failure I'll fix in my PR #47577

@tavplubix
Copy link
Copy Markdown
Member

@vitlibar, "flaky check" failures are usually blockers for merge (unless the failure was carefully investigated and it's obvious that it's not related). I have to revert this PR, see the comments in #47577

@vitlibar
Copy link
Copy Markdown
Member

@vitlibar, "flaky check" failures are usually blockers for merge

No, if they're not related

@vitlibar
Copy link
Copy Markdown
Member

vitlibar commented Mar 14, 2023

No, if they're not related

Ok, now I see that the changes actually were related.

So @SmitaRKulkarni you'll probably have to make this PR again and please use different names of the generated cluster configuration in test_disallow_concurrency.py and test_concurrency.py. Thanks @tavplubix for the help with investigation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants