Skip to content

Add shards to data type Map#47045

Closed
CurtizJ wants to merge 34 commits intoClickHouse:masterfrom
CurtizJ:sharded-map
Closed

Add shards to data type Map#47045
CurtizJ wants to merge 34 commits intoClickHouse:masterfrom
CurtizJ:sharded-map

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented Mar 1, 2023

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

TBD

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-feature Pull request with new product feature label Mar 1, 2023
@den-crane
Copy link
Copy Markdown
Contributor

Sorry, but I think "sharding" kinda is overused. I would name it buckets or baskets.

@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Mar 3, 2023

Ok, we can rename shards to buckets in that case.

@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Jun 9, 2024

This is an automated comment for commit af55627 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncIf it fails, ask a maintainer for help⏳ pending
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR❌ failure
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process⏳ pending
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
PR CheckChecks correctness of the PR's body❌ failure
Successful checks
Check nameDescriptionStatus
Docs checkBuilds and tests the documentation✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 20, 2024

Dear @CurtizJ, this PR hasn't been updated for a while. Will you continue working on it? If not, please close it. Otherwise, ignore this message.

2 similar comments
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Oct 22, 2024

Dear @CurtizJ, this PR hasn't been updated for a while. Will you continue working on it? If not, please close it. Otherwise, ignore this message.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Dec 24, 2024

Dear @CurtizJ, this PR hasn't been updated for a while. Will you continue working on it? If not, please close it. Otherwise, ignore this message.

@alexey-milovidov alexey-milovidov mentioned this pull request Dec 31, 2024
76 tasks
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Feb 25, 2025

Dear @CurtizJ, this PR hasn't been updated for a while. Will you continue working on it? If not, please close it. Otherwise, ignore this message.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Apr 29, 2025

Dear @CurtizJ, this PR hasn't been updated for a while. Will you continue working on it? If not, please close it. Otherwise, ignore this message.

@EmeraldShift
Copy link
Copy Markdown
Contributor

Is the plan for the number of shards/buckets to be a constant, or dynamic based on the number of keys? If so, maybe #78373 could be implemented completely by this PR instead of requiring anything new?

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 1, 2025

Dear @CurtizJ, this PR hasn't been updated for a while. Will you continue working on it? If not, please close it. Otherwise, ignore this message.

2 similar comments
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Sep 2, 2025

Dear @CurtizJ, this PR hasn't been updated for a while. Will you continue working on it? If not, please close it. Otherwise, ignore this message.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Nov 4, 2025

Dear @CurtizJ, this PR hasn't been updated for a while. Will you continue working on it? If not, please close it. Otherwise, ignore this message.

@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Dec 30, 2025

Maybe it will be implemented on top of shared data of JSON data type later, or maybe not.

@CurtizJ CurtizJ closed this Dec 30, 2025
@EmeraldShift
Copy link
Copy Markdown
Contributor

EmeraldShift commented Dec 30, 2025

Implementing a map via JSON storage (dynamic sybcolumns; shared-data, either sharded or Advanced), but without the front-end overhead and restrictions of JSON (e.g. UTF-8, #75017; Variant/Dynamic typing) would be ideal for lots of Observability use cases I have. It's a bit unfortunate that the innovative storage and the JSON front-end are so tightly coupled, or at least that the former isn't reusable. (tracked in #78373)

@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Dec 30, 2025

Implementing a map via JSON storage, but without the front-end overhead and restrictions of JSON

Yes, the idea is exactly about that.

@alexey-milovidov alexey-milovidov mentioned this pull request Dec 31, 2025
72 tasks
@Avogar
Copy link
Copy Markdown
Member

Avogar commented Mar 10, 2026

For those who subscubed to this PR, there is a new implementation for automatic buckets in Map type: #99200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature Pull request with new product feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants