replace[Regexp]{One,All}(): allow non-const pattern and replacement arguments#46589
Merged
replace[Regexp]{One,All}(): allow non-const pattern and replacement arguments#46589
Conversation
robot-ch-test-poll4
added
the
pr-improvement
rschu1ze
force-pushed
the
rs/nonconst-replace
branch
from
3689fb7 to
147505e
Compare
rschu1ze
changed the title
rschu1ze
force-pushed
the
rs/nonconst-replace
branch
from
147505e to
d39dbe8
Compare
rschu1ze
changed the title
rschu1ze
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
CurtizJ
reviewed
Apr 3, 2023
rschu1ze
force-pushed
the
rs/nonconst-replace
branch
from
77e9a8b to
5238bbd
Compare
rschu1ze
force-pushed
the
rs/nonconst-replace
branch
from
5238bbd to
a7c153f
Compare
Member
Author
CurtizJ
approved these changes
Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Functions replaceOne(), replaceAll(), replaceRegexpOne() and replaceRegexpAll() can now be called with non-const pattern and replacement arguments