Another fix for cluster copier#46433
Merged
robot-clickhouse-ci-1 merged 1 commit intomasterfrom Feb 16, 2023
Merged
Conversation
robot-ch-test-poll
added
the
pr-not-for-changelog
alexey-milovidov
approved these changes
Feb 15, 2023
nikitamikhaylov
approved these changes
Feb 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
It seems #46120 didn't fix the problem.
After checking logs, it simply exhausts the retries.
The first problem is that copy fault exhausts 2 attempts per partition piece number (we do 3 retries in total).
Still, we do retries on the entire partition also so we should have 3 * 3 attempts but because of a mistake a successful piece in the partition after a failed one would mark the entire partition as successful and break the partition loop (because it thinks it finished).
After the partition loop we check the partitions, find an incorrect piece and retry the entire table again. After 3 table retries we fail.
Close #30399 (final time I hope)
cc @nikitamikhaylov
Documentation entry for user-facing changes