Updates AsyncMetrics cgroup-memory to support cgroupv2#45999
Merged
alexey-milovidov merged 17 commits intoClickHouse:masterfrom Apr 28, 2023
Merged
Updates AsyncMetrics cgroup-memory to support cgroupv2#45999alexey-milovidov merged 17 commits intoClickHouse:masterfrom
alexey-milovidov merged 17 commits intoClickHouse:masterfrom
Conversation
robot-ch-test-poll
added
the
pr-improvement
mdonkers
reviewed
Feb 3, 2023
Member
|
Run Check — More than one changelog category specified: 'Improvement', '#37983' |
Member
|
@sichenzhao let's continue. |
Contributor
|
The |
… and extract shared code out
sichenzhao
requested review from
alexey-milovidov and
mdonkers
and removed request for
alexey-milovidov and
mdonkers
sichenzhao
requested review from
alexey-milovidov and
mdonkers
and removed request for
alexey-milovidov and
mdonkers
sichenzhao
requested review from
alexey-milovidov and
mdonkers
and removed request for
alexey-milovidov and
mdonkers
alexey-milovidov
approved these changes
Apr 23, 2023
Member
|
Ok. I didn't understand the changes, so I've rewritten it a little. |
Member
|
The changelog category was wrong, I have to edit it. |
alexey-milovidov
added
the
can be tested
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
alexey-milovidov
approved these changes
Apr 27, 2023
yokofly
added a commit
to timeplus-io/proton
that referenced
this pull request
Jan 31, 2024
porting ClickHouse/ClickHouse#45999 on Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add support for CGroup version 2 for asynchronous metrics about the memory usage and availability. This closes #37983.
Documentation entry for user-facing changes
This is an improvements over https://github.com/ClickHouse/ClickHouse/pull/45301/files, as previous PR supports only cgroupv1. This pr will fallback to cgroupv2 if cgroupv1 memory isn't defined.