Fix codec pipeline Delta (or DoubleDelta) + Gorilla#45615
Merged
Conversation
nickitat
approved these changes
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45195
Codec combinations
(Delta, Gorilla)and(DoubleDelta, Gorilla)(and possibly other codec pipelines where Gorilla is not the first codec) corrupt data. In case ofDelta, the reason is that the first codec writes a 11 byte header (containing the method, the item width etc.) and then compresses each input item to an equally wide output item. Gorilla then receives an input byte stream with an unaligned number of bytes. There exists code to store the unaligned bytes as is (*) but the code did not include them in the output stream byte size. This led to the situation that up to 7 bytes at the end of the compressed data (in case of double-precision FP values) were not read, creating random decompressed output data.(*) Gorilla deals with Delta-compressed inputs in a weird way: The delta header is chopped into 3+8 bytes (for double-precision floats), 3 bytes are copied as is into the output, 8 bytes are treated as first floating point value. That aside, Gorilla has its own mechanism of handling deltas between values and the combination Delta/DoubleDelta and Gorilla should be outlawed / made "suspicious". This will be done separately.
(also including some unrelated smaller improvements)
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):