Skip to content

Fix abort in destructor of ParallelParsingInputFormat#45498

Merged
CurtizJ merged 1 commit intoClickHouse:masterfrom
CurtizJ:fix-race-parallel-parsing
Jan 23, 2023
Merged

Fix abort in destructor of ParallelParsingInputFormat#45498
CurtizJ merged 1 commit intoClickHouse:masterfrom
CurtizJ:fix-race-parallel-parsing

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented Jan 23, 2023

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix rare abort in case when query is canceled and parallel parsing was used during its execution.

Fixes #42009.

@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label Jan 23, 2023
@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Jan 23, 2023

It's hard to add a good test because this bug reproduces very rarely. However has been reproducing before in test_storage_s3::test_s3_list_objects_failure (about 1 failure in 20 runs).

@antonio2368 antonio2368 self-assigned this Jan 23, 2023
@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Jan 23, 2023

Stress test: Part all_7_7_0 (state PreActive) not found in data_parts - #44975

@CurtizJ CurtizJ merged commit 61b0c4d into ClickHouse:master Jan 23, 2023
@yokofly yokofly mentioned this pull request Dec 15, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Abort in ~ParallelParsingInputFormat

3 participants