Revert "Revert "Remove redundant sorting""#45420
Merged
devcrafter merged 7 commits intomasterfrom Jan 24, 2023
Merged
Conversation
robot-ch-test-poll4
added
the
pr-not-for-changelog
+ disable debug logging
robot-ch-test-poll4
added
pr-improvement
Member
Author
|
After approve, I'll disable |
src/Processors/QueryPlan/Optimizations/removeRedundantSorting.cpp
Outdated
Show resolved
Hide resolved
src/Processors/QueryPlan/Optimizations/removeRedundantSorting.cpp
Outdated
Show resolved
Hide resolved
KochetovNicolai
approved these changes
Jan 24, 2023
…-43905-igor/remove_redundant_order_by
devcrafter
deleted the
revert-45414-revert-43905-igor/remove_redundant_order_by
branch
This was referenced Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Remove redundant sorting, for example, sorting related ORDER BY clauses in subqueries. Implemented on top of query plan. It does similar optimization as
optimize_duplicate_order_by_and_distinctregardingORDER BYclauses, but more generic, since it's applied to any redundant sorting steps (not only caused by ORDER BY clause) and applied to subqueries of any depth. Related to #42648