Fix no shared id during drop for the fourth time#45363
Merged
Conversation
robot-ch-test-poll3
added
the
pr-not-for-changelog
tavplubix
reviewed
Jan 18, 2023
Comment on lines
+7940
to
+7942
| else if (code == Coordination::Error::ZNONODE) /// table completely dropped, we can choose any id we want | ||
| { | ||
| LOG_DEBUG(log, "Table was completely drop, we can use anything as ID (will use {})", id); |
Member
There was a problem hiding this comment.
Why do we need an id if the table is completely dropped? What are we going to unlock in unlockSharedDataByID in this case?
Member
Author
There was a problem hiding this comment.
We will just check that this ID doesn't exist in ZK and assume parts unlocked, but I'm not 100% sure...
tavplubix
approved these changes
Jan 25, 2023
Comment on lines
+7968
to
+7970
| else if (code == Coordination::Error::ZNONODE) /// table completely dropped, we can choose any id we want | ||
| { | ||
| LOG_DEBUG(log, "Table was completely drop, we can use anything as ID (will use {})", id); |
Member
There was a problem hiding this comment.
Let's return Nil in this case
tavplubix
reviewed
Jan 25, 2023
…b.com:ClickHouse/ClickHouse into fix_hang_during_drop_in_zero_copy_replication
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixes #45224.