Prohibit specification of delta codecs before floating-point time series codecs#45277
Closed
Prohibit specification of delta codecs before floating-point time series codecs#45277
Conversation
robot-ch-test-poll1
added
the
pr-backward-incompatible
rschu1ze
changed the title
rschu1ze
force-pushed
the
no-manual-delta-before-ts-codec
branch
from
7c30c93 to
a45d458
Compare
Member
|
But it's still allowed if |
Member
Author
|
I noticed that 99% of this PR slipped into #45252 😱, that's why the diff looks weird. But luckily there seem to be no unwanted side effects. ClickHouse Integration Tests (tsan) [4/6]
ClickHouse Integration Tests (tsan) [6/6]
ClickHouse Stress Test *
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45195
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
It is no longer allowed to specify delta compression (i.e. using codecs "Delta" and "DoubleDelta") before specialized floating-point time series compression (i.e. using codecs "FPC" and "Gorilla"). Floating-point codecs implicitly apply delta compression (or something equivalent) to the data. The previous behavior can be restored with setting "allow_suspicious_codecs = 1".