Skip to content

Calculate only required columns in system.detached_parts#45181

Merged
kssenii merged 1 commit intoClickHouse:masterfrom
kssenii:fix-heavy-calculation-in-system-detached-parts
Jan 12, 2023
Merged

Calculate only required columns in system.detached_parts#45181
kssenii merged 1 commit intoClickHouse:masterfrom
kssenii:fix-heavy-calculation-in-system-detached-parts

Conversation

@kssenii
Copy link
Copy Markdown
Member

@kssenii kssenii commented Jan 11, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Closes #45177.

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 11, 2023
@kssenii kssenii force-pushed the fix-heavy-calculation-in-system-detached-parts branch from 99c0ba8 to 6499e8e Compare January 11, 2023 15:45
@tavplubix tavplubix self-assigned this Jan 11, 2023
@kssenii
Copy link
Copy Markdown
Member Author

kssenii commented Jan 12, 2023

Stateless tests (tsan, s3 storage) [3/5] — Tests are not finished, fail: 1

did not find anything in logs... stderr is empty, nothing in runlog, and in clickhouse-server.log only <Fatal> Application: Child process was terminated by signal 9 (KILL). If it is not done by 'forcestop' command or manually, the possible cause is OOM Killer (see 'dmesg' and look at the '/var/log/kern.log' for the details).

@kssenii kssenii merged commit d6289c3 into ClickHouse:master Jan 12, 2023
@tavplubix
Copy link
Copy Markdown
Member

tavplubix commented Jan 12, 2023

Stateless tests (tsan, s3 storage) [3/5] — Tests are not finished, fail: 1

did not find anything in logs... stderr is empty, nothing in runlog, and in clickhouse-server.log only <Fatal> Application: Child process was terminated by signal 9 (KILL). If it is not done by 'forcestop' command or manually, the possible cause is OOM Killer (see 'dmesg' and look at the '/var/log/kern.log' for the details).

Looks like OOM. It may be related to #44455

@nickitat, could you please take a look?

@nickitat
Copy link
Copy Markdown
Member

doesn't seem related. test actually didn't finished:

483769:2023.01.11 16:04:00.560851 [ 6290 ] {test_earik289_hash_table_sizes_stats_2400525607} <Trace> Aggregator: Merging aggregated data
483770:2023.01.11 16:04:00.561030 [ 6290 ] {test_earik289_hash_table_sizes_stats_2400525607} <Trace> Aggregator: Statistics updated for key=15678390843594786382: new sum_of_sizes=1000005, median_size=200001

but OOM happened 7 minutes later ...

@tavplubix
Copy link
Copy Markdown
Member

tavplubix commented Jan 12, 2023

doesn't seem related

According to the query I attached above, at the first time it failed like this in #44455 and then it started to fail in other PRs after #44455 was merged on 2023-01-09. So I'm pretty sure it's related.

test actually didn't finished

Yep, it means that OOM happened during the execution of that query (but yes, it's not clear why there are no log messages before OOM)

@nickitat
Copy link
Copy Markdown
Member

nickitat commented Jan 12, 2023

correlation is clear, you're right. but I don't see any reason. also it fails only under tsan as far as I see
#45287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

system.detached_parts calculates bytes_on_disk unconditionally

4 participants