Skip to content

Fix flaky test test_multiple_disks/test.py::test_rename#45180

Merged
kssenii merged 3 commits intoClickHouse:masterfrom
kssenii:fix-flacky-test-multiple-disks
Jan 13, 2023
Merged

Fix flaky test test_multiple_disks/test.py::test_rename#45180
kssenii merged 3 commits intoClickHouse:masterfrom
kssenii:fix-flacky-test-multiple-disks

Conversation

@kssenii
Copy link
Copy Markdown
Member

@kssenii kssenii commented Jan 11, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@kssenii kssenii mentioned this pull request Jan 11, 2023
Merged
@kssenii kssenii changed the title Fix flacky test test_multiple_disks/test.py::test_rename Fix flaky test test_multiple_disks/test.py::test_rename Jan 11, 2023
@qoega qoega force-pushed the fix-flacky-test-multiple-disks branch from 00d6db9 to e3a1af6 Compare January 11, 2023 22:51
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 11, 2023
@alexey-milovidov alexey-milovidov self-assigned this Jan 12, 2023
@qoega
Copy link
Copy Markdown
Member

qoega commented Jan 12, 2023 •
edited
Loading 

      assert len(disks) > 1
      NameError: name 'disks' is not defined

qoega
qoega reviewed Jan 12, 2023
View reviewed changes
@kssenii kssenii merged commit 75318e4 into ClickHouse:master Jan 13, 2023
@qoega
Copy link
Copy Markdown
Member

qoega commented Jan 18, 2023

Also failed test_multiple_disks/test.py::test_background_move[mt]

>           assert used_disks[0] == "external"
E           AssertionError: assert 'jbod1' == 'external'
E             - external
E             + jbod1

https://s3.amazonaws.com/clickhouse-test-reports/0/cfba9b19eb0941f4e40d216d55ef2a68f6d2cf5e/integration_tests__release__[2/2]/integration_run_parallel5_0.log

@qoega qoega mentioned this pull request Jan 18, 2023
Closed
@kssenii
Copy link
Copy Markdown
Member Author

kssenii commented Jan 18, 2023 •
edited
Loading

Also failed test_multiple_disks/test.py::test_background_move[mt]

the reason is most likely the same as in test_rename which I fixed in this PR, will fix..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qoega qoega qoega left review comments

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kssenii @qoega @alexey-milovidov @robot-ch-test-poll3