Move dmesg dumping out from runner to ci-runner.py#44667
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Dec 28, 2022
Merged
Move dmesg dumping out from runner to ci-runner.py#44667alexey-milovidov merged 1 commit intoClickHouse:masterfrom
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Conversation
robot-clickhouse-ci-1
added
the
pr-not-for-changelog
azat
force-pushed
the
tests/integration/dmesg-fix
branch
from
4169dff to
2ac9149
Compare
alesapin
approved these changes
Dec 28, 2022
alesapin
requested changes
Dec 28, 2022
runner is used by developers to run tests, while ci-runner.py is used only by CI scripts, and to avoid requiring CAP_SYSLOG for manual dmesg clear/dump had been moved. Also for manual runs this can be done manually. Signed-off-by: Azat Khuzhin <[email protected]>
azat
force-pushed
the
tests/integration/dmesg-fix
branch
from
2ac9149 to
03f80ba
Compare
alesapin
approved these changes
Dec 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runner is used by developers to run tests, while ci-runner.py is used only by CI scripts, and to avoid requiring CAP_SYSLOG for manual dmesg clear/dump had been moved.
Also for manual runs this can be done manually.
Follow-up for: #44535
Changelog category (leave one):