tests: get back test_distributed_queries_stress without flakiness#44537
Closed
azat wants to merge 2 commits intoClickHouse:masterfrom
Closed
tests: get back test_distributed_queries_stress without flakiness#44537azat wants to merge 2 commits intoClickHouse:masterfrom
azat wants to merge 2 commits intoClickHouse:masterfrom
Conversation
e51887b to
010682d
Compare
This was referenced Dec 26, 2022
1cfa1ee to
05ad7da
Compare
05ad7da to
74ff54b
Compare
daf99b3 to
5b6392f
Compare
Signed-off-by: Azat Khuzhin <[email protected]>
Sometimes one of containers got KILL'ed:
2022-11-20 15:06:43 [ 317 ] DEBUG : run container_id:roottestdistributedqueriesstress_node1_r1_1 detach:False nothrow:False cmd: ['bash', '-c', "echo 'select * from dist_two where key = 0;\n select * from dist_two where key = 1;\n select * from dist_two where key = 2;\n select * from dist_two where key = 3;\n select * from dist_two;' | clickhouse benchmark --concurrency=100 --cumulative --delay=0 --timelimit=3 --hedged_connection_timeout_ms=200 --connect_timeout_with_failover_ms=200 --connections_with_failover_max_tries=5 --async_socket_for_remote=0 --distributed_group_by_no_merge=2"] (cluster.py:1745, exec_in_container)
2022-11-20 15:06:43 [ 317 ] DEBUG : Command:['docker', 'exec', 'roottestdistributedqueriesstress_node1_r1_1', 'bash', '-c', "echo 'select * from dist_two where key = 0;\n select * from dist_two where key = 1;\n select * from dist_two where key = 2;\n select * from dist_two where key = 3;\n select * from dist_two;' | clickhouse benchmark --concurrency=100 --cumulative --delay=0 --timelimit=3 --hedged_connection_timeout_ms=200 --connect_timeout_with_failover_ms=200 --connections_with_failover_max_tries=5 --async_socket_for_remote=0 --distributed_group_by_no_merge=2"] (cluster.py:95, run_and_check)
2022-11-20 15:08:48 [ 317 ] DEBUG : Stderr:Loaded 5 queries. (cluster.py:105, run_and_check)
2022-11-20 15:08:48 [ 317 ] DEBUG : Exitcode:137 (cluster.py:107, run_and_check)
(Note 137 exit code is 128+KILL)
parallel1_0_dockerd.log:time="2022-11-20T15:08:48.244758252Z" level=debug msg="Revoking external connectivity on endpoint roottestdistributedqueriesstress_node1_r1_1 (82dfd051d379869bf885f90745cd4b097c70cd04bd3b4f86e49096358112fc51)"
parallel1_0_dockerd.log:time="2022-11-20T15:08:48.445809392Z" level=debug msg="82dfd051d379869bf885f90745cd4b097c70cd04bd3b4f86e49096358112fc51 (1c6863e).deleteSvcRecords(roottestdistributedqueriesstress_node1_r1_1, 172.16.8.2, <nil>, true) updateSvcRecord sid:82dfd051d3798
parallel1_0_dockerd.log:time="2022-11-20T15:08:48.526045522Z" level=debug msg="Releasing addresses for endpoint roottestdistributedqueriesstress_node1_r1_1's interface on network roottestdistributedqueriesstress_default"
The problem is likely OOM, that is the problem only under ASan with lots
of threads.
v2: tests: decrease concurrency for test_distributed_queries_stress
v3: increase timeout for internal command execution
v4: rebase on top of ClickHouse#44573
Fixes: ClickHouse#41776
Signed-off-by: Azat Khuzhin <[email protected]>
5b6392f to
c5a2d3f
Compare
alesapin
reviewed
Dec 27, 2022
Member
alesapin
left a comment
There was a problem hiding this comment.
I'm strongly against getting this test back. Integration tests are not designed for any stressful workloads. Your changes in the config for system tables and background pools are absolutely unreliable; we will add new system logs and new pools.
The complexity of this test proves that the integration tests framework is not designed for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes one of containers got KILL'ed:
(Note 137 exit code is 128+KILL)
The problem is likely OOM, that is the problem only under ASan with lots of threads.
Fixes: #41776
Supersedes: #44573
Changelog category (leave one):