Skip to content

Disallow arrayjoin in mutations#44447

Merged
KochetovNicolai merged 4 commits intomasterfrom
42637_Disallow_arrayJoin_in_mutations
Jan 5, 2023
Merged

Disallow arrayjoin in mutations#44447
KochetovNicolai merged 4 commits intomasterfrom
42637_Disallow_arrayJoin_in_mutations

Conversation

@SmitaRKulkarni
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Bug-fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Disallow arrayjoin in mutations closes #42637
Implementation:

  • Added a new parameter to ActionsVisitor::Data disallow_arrayjoin, which is set by MutationsIterator when it appends expression.
  • ActionsVisitor uses disallow_arrayjoin and throws error when its used with mutations. Testing:
  • Added test for the same 02504_disallow_arrayjoin_in_mutations.sql.

Implementation:
* Added a new parameter to ActionsVisitor::Data disallow_arrayjoin, which is set by MutationsIterator when it appends expression.
* ActionsVisitor uses disallow_arrayjoin and throws error when its used with mutations.
Testing:
* Added test for the same 02504_disallow_arrayjoin_in_mutations.sql.
@SmitaRKulkarni SmitaRKulkarni marked this pull request as draft December 20, 2022 17:56
@SmitaRKulkarni SmitaRKulkarni marked this pull request as ready for review December 23, 2022 15:44
@KochetovNicolai KochetovNicolai self-assigned this Jan 2, 2023
…terpreter::addStreamsForLaterStages - 42637 Disallow arrayJoin in mutations
@KochetovNicolai KochetovNicolai merged commit f629425 into master Jan 5, 2023
@KochetovNicolai KochetovNicolai deleted the 42637_Disallow_arrayJoin_in_mutations branch January 5, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

arrayJoin in mutation can lead to logical error Trying to get non existing mark 2, while size is 2

2 participants