RabbitMQ - fix writing many small blocks by flushing data only exactly by flush_interval_ms or by max_block_size#44404
Merged
kssenii merged 18 commits intoClickHouse:masterfrom Feb 3, 2023
Conversation
robot-ch-test-poll3
added
the
pr-bugfix
kssenii
force-pushed
the
storage-rabbitmq-fix-flush
branch
from
5d8bc6f to
499565a
Compare
Avogar
approved these changes
Dec 21, 2022
Member
|
I merged my big PR with changes aroung RabbitMQ and it produced complex conflicts, if you will need help to resolve them, you can ask me. |
|
Any news on this getting merged? Big issue for us :( |
Member
Author
|
@Recodify, I need to fix some remaining failing tests... Will try to finish this week or at the beginning of the next. |
… storage-rabbitmq-fix-flush
Closed
Member
Author
|
🥲 |
This was referenced Apr 1, 2023
kssenii
added a commit
that referenced
this pull request
Apr 7, 2023
Fix cpu usage in rabbitmq (was worsened in 23.2 after #44404)
robot-clickhouse
added a commit
that referenced
this pull request
Apr 7, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Apr 7, 2023
Enmk
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Jun 24, 2023
…-flush RabbitMQ - fix writing many small blocks by flushing data only exactly by flush_interval_ms or by max_block_size
Enmk
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Jun 26, 2023
Fix cpu usage in rabbitmq (was worsened in 23.2 after ClickHouse#44404) cherry-picked d5889a4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Flush data exactly by
rabbitmq_flush_interval_msor byrabbitmq_max_block_sizeinStorageRabbitMQ. Closes #42389. Closes #45160.