Skip to content

Hotfix for "check_status.tsv doesn't exists" in stress tests #44197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tavplubix merged 4 commits into from
Dec 15, 2022
Merged

Hotfix for "check_status.tsv doesn't exists" in stress tests #44197

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49f3e8e
Update run.sh
tavplubix Dec 13, 2022
f68a407
Update docker/test/stress/run.sh
tavplubix Dec 13, 2022
3f33619
Update run.sh
tavplubix Dec 14, 2022
f6eb790
Merge branch 'master' into tavplubix-patch-2
tavplubix Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions docker/test/stress/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,23 +127,24 @@ EOL

function stop()
{
local max_tries=""
if [ -n "$1" ]
then
max_tries="--max-tries $1"
fi
Copy link
Copy Markdown
Member

@azat azat Dec 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially there was a check, that had been removed in dc52a40, and that's why it started to fail.


local pid
# Preserve the pid, since the server can hung after the PID will be deleted.
pid="$(cat /var/run/clickhouse-server/clickhouse-server.pid)"

clickhouse stop $max_tries --do-not-kill && return

if [ -n "$1" ]
then
# temporarily disable it in BC check
clickhouse stop --force
return
fi

# We failed to stop the server with SIGTERM. Maybe it hang, let's collect stacktraces.
kill -TERM "$(pidof gdb)" ||:
sleep 5
echo "thread apply all backtrace (on stop)" >> /test_output/gdb.log
gdb -batch -ex 'thread apply all backtrace' -p "$pid" | ts '%Y-%m-%d %H:%M:%S' >> /test_output/gdb.log
timeout 30m gdb -batch -ex 'thread apply all backtrace' -p "$pid" | ts '%Y-%m-%d %H:%M:%S' >> /test_output/gdb.log
clickhouse stop --force
}

Expand Down Expand Up @@ -431,7 +432,7 @@ else

clickhouse-client --query="SELECT 'Tables count:', count() FROM system.tables"

stop 180
stop 1
mv /var/log/clickhouse-server/clickhouse-server.log /var/log/clickhouse-server/clickhouse-server.backward.stress.log

# Start new server
Expand Down