Merged
Conversation
devcrafter
force-pushed
the
igor/remove_redundant_distinct
branch
from
d41aa2b to
60d5862
Compare
devcrafter
changed the base branch from
igor/remove_redundant_order_by
to
master
- it doesn't consider prefixes yet
devcrafter
force-pushed
the
igor/remove_redundant_distinct
branch
from
60d5862 to
db6e1ac
Compare
robot-ch-test-poll2
added
the
pr-improvement
rschu1ze
reviewed
Dec 19, 2022
src/Processors/QueryPlan/Optimizations/QueryPlanOptimizationSettings.h
Outdated
Show resolved
Hide resolved
src/Processors/QueryPlan/Optimizations/removeRedundantDistinct.cpp
Outdated
Show resolved
Hide resolved
rschu1ze
reviewed
Dec 19, 2022
src/Processors/QueryPlan/Optimizations/removeRedundantDistinct.cpp
Outdated
Show resolved
Hide resolved
src/Processors/QueryPlan/Optimizations/removeRedundantDistinct.cpp
Outdated
Show resolved
Hide resolved
src/Processors/QueryPlan/Optimizations/removeRedundantDistinct.cpp
Outdated
Show resolved
Hide resolved
src/Processors/QueryPlan/Optimizations/removeRedundantDistinct.cpp
Outdated
Show resolved
Hide resolved
rschu1ze
reviewed
Dec 19, 2022
src/Processors/QueryPlan/Optimizations/removeRedundantDistinct.cpp
Outdated
Show resolved
Hide resolved
rschu1ze
reviewed
Dec 19, 2022
src/Processors/QueryPlan/Optimizations/removeRedundantDistinct.cpp
Outdated
Show resolved
Hide resolved
Member
Author
|
Need to wait for DISTINCT fix in Planner. Currently, Planner creates only preliminary DISTINCT steps. |
rschu1ze
approved these changes
Feb 3, 2023
src/Processors/QueryPlan/Optimizations/removeRedundantDistinct.cpp
Outdated
Show resolved
Hide resolved
src/Processors/QueryPlan/Optimizations/removeRedundantDistinct.cpp
Outdated
Show resolved
Hide resolved
src/Processors/QueryPlan/Optimizations/removeRedundantDistinct.cpp
Outdated
Show resolved
Hide resolved
always checking AggregatingStep and skipping Rollup, Cube, TotalsHaving
This was referenced Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Remove redundant DISTINCT clauses in query (subqueries). Implemented on top of query plan. It does similar optimization as
optimize_duplicate_order_by_and_distinctregarding DISTINCT clauses. Can be enabled viaquery_plan_remove_redundant_distinctsetting. Related to #42648