Skip to content

Fix logical error in right storage join with using#43963

Merged
vdimir merged 1 commit intomasterfrom
vdimir/storage_join_right_assert
Dec 7, 2022
Merged

Fix logical error in right storage join with using#43963
vdimir merged 1 commit intomasterfrom
vdimir/storage_join_right_assert

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Dec 5, 2022

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Fix logical error in right storage join with using

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-bugfix Pull request with bugfix, not backported by default label Dec 5, 2022
@nickitat nickitat self-assigned this Dec 5, 2022
@vdimir vdimir force-pushed the vdimir/storage_join_right_assert branch from 1f99d0e to 310637c Compare December 6, 2022 09:55
@vdimir vdimir force-pushed the vdimir/storage_join_right_assert branch from 310637c to 3bdce39 Compare December 6, 2022 11:47
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Dec 7, 2022

CI failures (3bdce39) :

AST fuzzer (msan) — Lost connection to server. See the logs. Details

OOM in dmesg

2022.12.06 16:32:35.774934 [ 373 ] {} <Trace> SystemLog (system.metric_log): Flushed system log up to offset 578
2022.12.06 16:32:36.000176 [ 384 ] {} <Trace> AsynchronousMetrics: MemoryTracking: was 58.68 GiB, peak 58.68 GiB, free memory in arenas 0.00 B, will set to 59.73 GiB (RSS), difference: 1.05 GiB
2022.12.06 16:32:36.000284 [ 384 ] {} <Debug> MemoryTracker: Current memory usage (total): 59.73 GiB.
2022.12.06 16:32:39.570307 [ 150 ] {} <Fatal> Application: Child process was terminated by signal 9 (KILL). If it is not done by 'forcestop' command or manually, the possible cause is OOM Killer (see 'dmesg' and look at the '/var/log/kern.log' for the details).

Integration tests (release) [3/4] — fail: 1, passed: 471, flaky: 0 Details

test_merge_tree_hdfs/test.py::test_attach_detach_partition: #41145 (comment)

Stress test (ubsan) — Backward compatibility check: Error message in clickhouse-server.log (see bc_check_error_messages.txt) Details

2022.12.06 22:13:46.799608 [ 302305 ] {} <Error> test_xm99vh09.src_13: while loading part 3_1_1_0 on path data/test_xm99vh09/src_13/3_1_1_0: Code: 499. DB::Exception: The specified key does not exist.: while reading key: test/rmy/xsesqacizwbofnuboqaltqwgbfgjm, from bucket: test. (S3_ERROR), Stack trace (when copying this message, always include the lines below):
2022.12.06 22:13:46.799917 [ 302305 ] {} <Error> test_xm99vh09.src_13: Detaching broken part /var/lib/clickhouse/disks/s3/data/test_xm99vh09/src_13/3_1_1_0 (size: 603.00 B). If it happened after update, it is likely because of backward incompatibility. You need to resolve this manually
2022.12.06 22:13:49.036260 [ 302221 ] {} <Error> DiskObjectStorageTransaction: An error occurred while executing transaction's operation #0 (RemoveManyObjectStorageOperation (paths size: 11, keep all batch false, files to keep )): Code: 107. DB::ErrnoException: Cannot open file /var/lib/clickhouse/disks/s3/data/system/part_log/delete_tmp_202212_373_373_0/data.mrk3, errno: 2, strerror: No such file or directory. (FILE_DOESNT_EXIST), Stack trace (when copying this message, always include the lines below):
2022.12.06 22:13:49.036460 [ 302221 ] {} <Error> system.part_log: Cannot quickly remove directory /var/lib/clickhouse/disks/s3/data/system/part_log/delete_tmp_202212_373_373_0 by removing files; fallback to recursive removal. Reason: Code: 107. DB::ErrnoException: Cannot open file /var/lib/clickhouse/disks/s3/data/system/part_log/delete_tmp_202212_373_373_0/data.mrk3, errno: 2, strerror: No such file or directory. (FILE_DOESNT_EXIST) (version 22.12.1.1)

#41369

@vdimir vdimir requested a review from nickitat December 7, 2022 09:58
@vdimir vdimir merged commit f4bc44f into master Dec 7, 2022
@vdimir vdimir deleted the vdimir/storage_join_right_assert branch December 7, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants