Hold ProcessListEntry a bit longer in case of exception from Interpreter#43847
Merged
Hold ProcessListEntry a bit longer in case of exception from Interpreter#43847
Conversation
robot-ch-test-poll
added
the
pr-not-for-changelog
tavplubix
force-pushed
the
fix_some_flaky_tests2
branch
from
694a006 to
d557f4a
Compare
tavplubix
force-pushed
the
fix_some_flaky_tests2
branch
from
101cf9d to
6adbc21
Compare
novikd
approved these changes
Dec 1, 2022
Member
Author
|
Checks did not start for some reason |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
It will fix some flaky tests like https://s3.amazonaws.com/clickhouse-test-reports/43781/a00fc4907b74fe2f8a39729e041a2a3ee28904b2/stateless_tests__debug__s3_storage__[6/6].html
Logs: https://pastila.nl/?02aa875b/918831cf0f4ca083cbff902adea58344
We used to remove ProcessListEntry before some dtors called and query is actually finished