Skip to content

Use disk operation to serialize and deserialize meta files of StorageFilelog#43826

Merged
Avogar merged 7 commits intoClickHouse:masterfrom
ucasfl:filelog-fix
Dec 13, 2022
Merged

Use disk operation to serialize and deserialize meta files of StorageFilelog#43826
Avogar merged 7 commits intoClickHouse:masterfrom
ucasfl:filelog-fix

Conversation

@ucasfl
Copy link
Copy Markdown
Collaborator

@ucasfl ucasfl commented Nov 30, 2022

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Closes #43800.

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 30, 2022
@ucasfl ucasfl changed the title Filelog fix Use disk operation to serialize and deserialize meta files of StorageFilelog Nov 30, 2022
@Avogar Avogar self-assigned this Nov 30, 2022
Copy link
Copy Markdown
Member

@Avogar Avogar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but smth strange with tests

@Avogar
Copy link
Copy Markdown
Member

Avogar commented Dec 7, 2022

Seems like tests failures are related. Running test 02025_storage_filelog_virtual_col.sh leads to Memory limit (total) exceeded errors in server

@ucasfl
Copy link
Copy Markdown
Collaborator Author

ucasfl commented Dec 13, 2022

Tests failed should not related.

@Avogar
Copy link
Copy Markdown
Member

Avogar commented Dec 13, 2022

AST fuzzer (ubsan) - #44191

@Avogar Avogar merged commit a4525bb into ClickHouse:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BC check: StorageFileLog: Read meta file failed

3 participants