Skip to content

Fix backward compatibility check#43436

Merged
alexey-milovidov merged 1 commit intomasterfrom
fix-bc-check
Nov 22, 2022
Merged

Fix backward compatibility check#43436
alexey-milovidov merged 1 commit intomasterfrom
fix-bc-check

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

This closes #39174.

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 21, 2022
@tavplubix
Copy link
Copy Markdown
Member

Sometimes this check catches real bugs, for example #38643 or #39197
Suppression for MutateFromLogEntryTask is probably too generic

@alexey-milovidov
Copy link
Copy Markdown
Member Author

Ok, but the issue has existed since July, and we are suffering every time. Let's first make it clear and then improve.

@tavplubix
Copy link
Copy Markdown
Member

Ok, but the issue has existed since July, and we are suffering every time

Actually I have not seen it for a long time until now. And the issue is mostly about errors like Cannot parse string (it's usually false positive). When you see Missing columns it's 90% bug.

@alexey-milovidov
Copy link
Copy Markdown
Member Author

Editing this script feels fragile to me.
Let's do the following: - merge this PR as a first step; - you can edit this script to make the pattern more specific.

@tavplubix tavplubix self-assigned this Nov 22, 2022
@alexey-milovidov alexey-milovidov merged commit ae8391c into master Nov 22, 2022
@alexey-milovidov alexey-milovidov deleted the fix-bc-check branch November 22, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade check fails if threre's invalid mutation

3 participants