Fix possible "No column to rollback" logical error during INSERT into Buffer#43336
Merged
davenger merged 3 commits intoClickHouse:masterfrom Nov 23, 2022
Merged
Fix possible "No column to rollback" logical error during INSERT into Buffer#43336davenger merged 3 commits intoClickHouse:masterfrom
davenger merged 3 commits intoClickHouse:masterfrom
Conversation
Signed-off-by: Azat Khuzhin <[email protected]>
…hmark Using clickhouse-benchmark is better since it can send way more queries, especially if you have debug/sanitizers build. Signed-off-by: Azat Khuzhin <[email protected]>
robot-clickhouse
added
the
pr-bugfix
azat
commented
Nov 17, 2022
… Buffer In case of concurrent INSERT and SELECT, and memory pressure it is possible to get this error, if you are very lucky. Signed-off-by: Azat Khuzhin <[email protected]>
azat
force-pushed
the
buffer/fix-rollback
branch
from
a9773f9 to
aa77bea
Compare
davenger
approved these changes
Nov 23, 2022
Member
|
AST Fuzzer (asan) failure: #43202 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix possible (very unlikely) "No column to rollback" logical error during INSERT into Buffer
In case of concurrent INSERT and SELECT, and memory pressure it is
possible to get this error, if you are very lucky.
More details you will find in the comments in the code and tests
Fixes: #42740 (cc @tavplubix @alexey-milovidov )