Skip to content

Revert "Revert "S3 request per second rate throttling""#43335

Merged
serxa merged 2 commits intomasterfrom
revert-43306-revert-43014-disk-s3-throttler
Nov 18, 2022
Merged

Revert "Revert "S3 request per second rate throttling""#43335
serxa merged 2 commits intomasterfrom
revert-43306-revert-43014-disk-s3-throttler

Conversation

@serxa
Copy link
Copy Markdown
Member

@serxa serxa commented Nov 17, 2022

Reverts #43306

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 17, 2022
@serxa
Copy link
Copy Markdown
Member Author

serxa commented Nov 18, 2022

All fails look unrelated

@serxa serxa merged commit d05223e into master Nov 18, 2022
@serxa serxa deleted the revert-43306-revert-43014-disk-s3-throttler branch November 18, 2022 15:22
@tavplubix
Copy link
Copy Markdown
Member

Stress test (asan) — Sanitizer assert (in stderr.log)

All fails look unrelated

@serxa, yes, this failure is probably not related, but it's still interesting. Please create an issue about that (if it's not created already). We should never ignore failures like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants