Conversation
robot-ch-test-poll2
added
the
pr-not-for-changelog
Member
Why? Queries that try to access S3 will just fail, it's not a problem. Unavailability of S3 should not crash the server |
tavplubix
reviewed
Nov 16, 2022
| # echo ${path//.sql.j2/.gen.sql} | ||
| # but it doesn't allow to use regex | ||
| echo "$path" | sed 's/\.sql\.j2$/.gen.sql/' | ||
| if grep '^-- Tag' "$path" | grep "needs s3" >/dev/null 2>&1; then |
Member
There was a problem hiding this comment.
Do I understand correctly that it looks for a line like the following?
The comment on the second line is not mandatory, it has no effect and can be omitted. Moreover, it may contain arbitrary text like "requires s3" or "needs minio" or whatever instead of "needs s3".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...