stress: increase timeout for server waiting after TERM#43277
stress: increase timeout for server waiting after TERM#43277alexey-milovidov merged 3 commits intoClickHouse:masterfrom
Conversation
In this example Stress tests have found a real issue: after #42222 removal outdated parts from DiskS3 slowed down significantly. However, the only reason why we call I would prefer to fix the issue instead of increasing timeout. But maybe it's okay temporarily increase it and then decrease back after removing |
Yep, this is just a workaround to avoid noisy CI, and I think eventually it will be a problem even with increased timeout, but just not that frequent. |
|
Why 5 functional tests failed???? |
|
Let's see is it stable |
Some of these tests are known to be flaky in debug build (they are just too slow), and usually they fail all together |
|
@azat |
52f12e5 to
7346762
Compare
Yes, this is because it was used with the binary from previous version. Fixed. |
Increasing timeout may help in case of slow server (debug, sanitizers). Signed-off-by: Azat Khuzhin <[email protected]>
Greater timeout after TERM may reduce about of KILL, let's try. Signed-off-by: Azat Khuzhin <[email protected]>
Signed-off-by: Azat Khuzhin <[email protected]>
7346762 to
ca16f51
Compare
|
FWIW Not a lot of difference after merging this (play). |
|
It did not help. |
|
@alexey-milovidov It hasn't been used at that time, since it was broken in #44197, , and was gotten back in minor cleanup - #45136 |
porting clickhouse/clickhouse#ClickHouse/ClickHouse#43277 on Nov 27, 2022
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
stress: increase timeout for server waiting after TERM
Greater timeout after TERM may reduce about of KILL (like in 1), let's try.