Support optimize_group_by_function_keys on top of QueryTree#43261
Merged
kitaisreal merged 10 commits intomasterfrom Jan 18, 2023
Merged
Support optimize_group_by_function_keys on top of QueryTree#43261kitaisreal merged 10 commits intomasterfrom
kitaisreal merged 10 commits intomasterfrom
Conversation
robot-ch-test-poll
added
the
pr-improvement
kitaisreal
suggested changes
Jan 16, 2023
| @@ -0,0 +1,17 @@ | |||
| EXPLAIN QUERY TREE run_passes=1 | |||
Contributor
There was a problem hiding this comment.
Need to rename test into 02481_analyzer_optimize_grouping_sets_keys.sql, that way it is easy to run all analyzer tests.
Contributor
There was a problem hiding this comment.
For this test we want to test GROUP BY, we do not need to add HAVING, ORDER BY, complex projection. Otherwise correctness of tests are hard to verify.
Member
Author
There was a problem hiding this comment.
I renamed the test, but see no point in editing it because I just copied queries from tests with the old analyzer a modified them a little bit.
Contributor
|
@novikd need to fix fast test failures |
kitaisreal
approved these changes
Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Support
optimize_group_by_function_keysin the new analyzer architecture. Also, add support for optimizing GROUPING SETS keys. Part of #42648.Requires to resolve #43257 before merging.