[Analyzer migration] Enable optimize_duplicate_order_by_and_distinct (ORDER BY part)#43229
Closed
devcrafter wants to merge 13 commits intomasterfrom
Closed
[Analyzer migration] Enable optimize_duplicate_order_by_and_distinct (ORDER BY part)#43229devcrafter wants to merge 13 commits intomasterfrom
devcrafter wants to merge 13 commits intomasterfrom
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
novikd
reviewed
Nov 15, 2022
Member
Author
|
Contributor
|
@devcrafter, @novikd we need to discuss, on which stage we want to substitute subqueries instead views. In most DBMS this is done during rewriting stage (can be done in QueryTreePass), althought we need to save information about Storage for RBAC to work, probably we would have to modify query node, union node. |
Member
Author
|
Closed in favor #45420 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Implements part of
optimize_duplicate_order_by_and_distinctoptimization, - remove unnecessaryORDER BYin subqueries if possible. Part of #42648