Stop ConfigReloader first to avoid data race#43201
Merged
antonio2368 merged 1 commit intomasterfrom Nov 14, 2022
Merged
Conversation
robot-ch-test-poll
added
the
pr-not-for-changelog
This was referenced Nov 13, 2022
devcrafter
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
TSan caught a race during shutdown: https://s3.amazonaws.com/clickhouse-test-reports/43192/6599016aec6998be11decfb69c5c64802298028c/integration_tests__tsan__%5B2/4%5D.html
During termination, first
SCOPE_EXITstarted which stops servers.ConfigReloaderrecreates servers (because of the test) in parallel - it's stopped only in the secondSCOPE_EXIT. Because of that, the destructor is called on a server that is not stopped.I don't think there is anything critical here or a way for user to notice this so I didn't put any changelog.