Do not include libcxx library for C#43166
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Nov 22, 2022
Merged
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
azat
force-pushed
the
build/libcxx-only-for-cxx
branch
from
d05cf74 to
3735630
Compare
If you will have the same header in both libraries you may have some tricky failures. And there is at least one header that exists in both: stdatomic.h Right now there is a workaround for this header, that allows to use C++ version of this header for C - the workaround is called "set _LIBCPP_COMPILER_CLANG_BASED not only for CXX" [1] and use include_next [2]. [1]: https://github.com/ClickHouse/libcxx/blob/9a457ab3c64a533a06922b386b284215c17ce627/include/__config#L39 [2]: https://github.com/ClickHouse/libcxx/blob/9a457ab3c64a533a06922b386b284215c17ce627/include/stdatomic.h#L223-L231 However ClickHouse#42730 changes this, and now it fails to compile because of this. Signed-off-by: Azat Khuzhin <[email protected]>
azat
force-pushed
the
build/libcxx-only-for-cxx
branch
from
3735630 to
ddfea23
Compare
robot-ch-test-poll1
added
the
submodule changed
Member
Author
|
Failures unrelated:
|
alexey-milovidov
approved these changes
Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you will have the same header in both libraries you may have some tricky failures.
And there is at least one header that exists in both: stdatomic.h
Right now there is a workaround for this header, that allows to use C++ version of this header for C - the workaround is called "set _LIBCPP_COMPILER_CLANG_BASED not only for CXX" 1 and use include_next 2.
However #42730 (cc @rschu1ze) changes this, and now it fails to compile because of this.
Changelog category (leave one):